Fix default_credentials in azure storage provider#4619
Merged
Conversation
Member
|
Can you squash @switchboardOp looks like GHA is stuck |
it can now return a client using default azure credentials updated docs to include information on Azure Workload Identity Signed-off-by: Lucas Melchior <lucasmelchior@flywheel.io> fix anchor link in docs Signed-off-by: Lucas Melchior <lucasmelchior@flywheel.io>
Contributor
Author
|
CI still looks hung up @milosgajdos maybe waiting on approval? 🤷 |
Member
|
Let me try closing and reopening |
milosgajdos
approved these changes
Apr 9, 2025
davidspek
approved these changes
Apr 9, 2025
davidspek
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the contribution!
Contributor
Author
|
Thanks for getting it in so fast. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
newClient can now return a client using default azure credentials.
updated docs to include information on Azure Workload Identity.
Fixes #4618