Skip to content

feat(configuration): support mtls auth mod#4537

Merged
milosgajdos merged 4 commits into
distribution:mainfrom
vitshev:client_auth_mod
Dec 17, 2024
Merged

feat(configuration): support mtls auth mod#4537
milosgajdos merged 4 commits into
distribution:mainfrom
vitshev:client_auth_mod

Conversation

@vitshev

@vitshev vitshev commented Dec 16, 2024

Copy link
Copy Markdown
Contributor

Hi! This PR allows setting the tls.ClientAuthType parameter in TLS configurations. It’s useful for supporting both clients with and without certificates.

Example:

tls:
  clientauth: verify-client-cert-if-given

This was added to support custom access controllers needing flexible client certificate handling.

@github-actions github-actions Bot added area/config Related to registry config area/docs labels Dec 16, 2024
@vitshev vitshev force-pushed the client_auth_mod branch 3 times, most recently from d12ca05 to 8fcebcc Compare December 16, 2024 13:13
Comment thread configuration/configuration.go Outdated
Signed-off-by: vitshev <vitshev@tracto.ai>
Signed-off-by: vitshev <vitshev@tracto.ai>
Comment thread configuration/configuration_test.go Outdated
Comment thread configuration/configuration.go Outdated
vitshev and others added 2 commits December 16, 2024 22:30
Co-authored-by: Milos Gajdos <milosgajdos83@gmail.com>
Signed-off-by: Vitshev <vitshev@tracto.ai>

@milosgajdos milosgajdos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davidspek davidspek left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@milosgajdos milosgajdos merged commit 1c62898 into distribution:main Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/config Related to registry config area/docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants