Do we need an entry in .mailmap as well, to prevent being listed twice? https://github.com/distribution/distribution/blob/main/.mailmap

Maybe? Those are from commits, though.

Yeah, it would result in duplicate entries in AUTHORS if we regenerate it, so I thought it might be worth having that already done so that we don't have to fix it at that point.

otherwise LGTM

Yeah, it would result in duplicate entries in AUTHORS if we regenerate it

Duplicate as 2 emails for the same authors is fine for me because those commits were signed with different email addresses. I don't know what the problem is with that.

Right, but I think the purpose of the AUTHORS file is to show each author, not what e-mail they historically used.

Do we need an entry in .mailmap as well, to prevent being listed twice? https://github.com/distribution/distribution/blob/main/.mailmap

Seems like the .mailmap already refers to the new email address - all contributions have likely been made using the gmail address rather than the Mirantis one. THink we're good

Seems like the .mailmap already refers to the new email address

Ah, right, but it doesn't have a mapping for the e-mail address 🤔

all contributions have likely been made using the gmail address rather than the Mirantis one. THink we're good

That's a good point; I did not check git log on that part, so if that's the case, it may not be needed

Ah, right, but it doesn't have a mapping for the e-mail address 🤔

Yeah, I'm not sure why. Maybe Kyle never actually committed anything and the email address there is just from the merge commits