fix: character controller: walls less likely to trigger ground detection#655
Merged
ThierryBerger merged 2 commits intodimforge:masterfrom Jun 17, 2024
Conversation
thanks to a bigger epsilon.
sebcrozet
approved these changes
Jun 17, 2024
Member
|
For the record, bumping the epsilon to |
ThierryBerger
commented
Jun 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
While trying out dimforge/bevy_rapier#476 ; I noticed I could jump when hitting walls (particularly on the junction of 2 walls).
Bug analysis
When printing the normal dot value, I had this value in air:
1.7037166e-5(hitting a wall perfectly perpendicular)The current epsilon being
1.0e-5; this dot check istrue, thenis_groundedistrue, and the character can jump in the example from dimforge/bevy_rapier#476.Solution decription
I think it makes sense to relax this epsilon ; alternatively we could:
But that first fix is probably an easy sufficient fix ?
I'm wondering if this has anything to do with scaled transforms ?