Check whether the current user has access to KVM before attempting to add udev rule#141
Merged
gustavderdrache merged 2 commits intoDeterminateSystems:mainfrom Apr 23, 2025
Merged
Conversation
…pting to add a udev rule.
gustavderdrache
approved these changes
Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I've recently started using this action with a runner using act, which uses docker containers to provide the standard actions environments (such as
ubuntu-latest). I'd like to use this action to install nix with kvm enabled, but currently the KVM setup fails due to udev not being installed in the docker container.KVM is already fully functional inside the container (I've passed
/dev/kvmto the docker container and added the runner user to thekvmgroup), so installing udev and modifying rules is unnecessary.This PR checks whether KVM is available to the current user, and if it is then it skips setting up udev rules.
Checklist