Conversation
stephenmathieson
previously requested changes
Feb 10, 2023
Member
stephenmathieson
left a comment
There was a problem hiding this comment.
I'm very worried about the new global.
Comment on lines
+46
to
+47
| window.partialResults ??= ''; | ||
| window.partialResults += chunk; |
Member
There was a problem hiding this comment.
What happens if the site under test has this global defined? We should at least prefix this with "axe".
Contributor
Author
There was a problem hiding this comment.
finshRun gets run in a black page, so there are no pre-defined user globals.
| options | ||
| }: FinishRunParams): Promise<AxeResults> => { | ||
| return window.axe.finishRun(partialResults, options); | ||
| return window.axe.finishRun(JSON.parse(window.partialResults), options); |
Member
There was a problem hiding this comment.
Why can't partialResults be passed in here?
Contributor
Author
There was a problem hiding this comment.
That was the problem. It was too big to be put here on it's own
Didn't know finishRun happened in a blank page
stephenmathieson
approved these changes
Feb 13, 2023
This was referenced Feb 15, 2023
This was referenced Mar 28, 2023
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #666