chore: remove duplicate suppression rules from base that are in the generated branch#8138
Merged
jeremylong merged 1 commit intomainfrom Nov 20, 2025
Merged
Conversation
chadlwilson
approved these changes
Nov 19, 2025
Collaborator
chadlwilson
left a comment
There was a problem hiding this comment.
LGTM. I diffed to generatedSuppressions and numbers for overlapping lines looks about right. Also spot checked a number to see they are still within the generatedSuppressions.
Collaborator
|
Most of the stuff that is difficult to diff here is due to all the edits to the After this PR, we can perhaps remove the old ones from Alternatively we could sync them across to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes duplicate suppressions from base file that exist in the generated branch.