fix: Make HC5 Downloader honor the connection- and readTimeout settings that the old URLConnectionFactory based downloads observed#7437
Conversation
…gs that the old URLConnectionFactory based downloads observed
|
@jeremylong When do you expect to release 12.1.1? This fix helps should relieve some of the pressure on the NVD API since their servers aren't timing out the connection either. I'm surprised NIST servers will let a connection stay open forever. Yesterday, I had a build where the same connection was stuck for 24 hours, and they never timed out the connection. @aikebah I will sync the change locally and test and see if I can complete a download with this change and report back. |
|
I'm testing with the changes, and it's not helping the situation. The download has been hung at 43% now for over 30 minutes. I expected the connection to timeout after 60 seconds and to see a retry, but that hasn't happened. [INFO] --- dependency-check:12.1.1-SNAPSHOT:check (default) @ myapp --- I'm going to see if I can attach a debugger and see exactly where things are hanging up. If you have any suggestions of where I might want to set a breakpoint, that might save me some time getting to the bottom of this. |
|
@aikebah @jeremylong I uploaded a patch file to #7418 that does seem to address the problems with the downloads hanging. It's not a properly integrated fix because I wasn't sure how to externalize the configuration parameters so they could be configured as plugin properties. I just uploaded a patch vs an incomplete pull request. I figured someone that knows the code better could integrate it better. |
|
Is there already a timeline when this pull request might be merged/the next version (12.1.1) will be released? |
|
@matthiaso I'm hoping we will release the next version this weekend. I'm working on something else that will help. |
Description of Change
Restores the timeouts (read and connect), including their configurability, that applied to the old UrlConnectionFactory based downloads also for the traffic that now uses the apache HttpClient5 based http clients.
Related issues
Have test cases been added to cover the new functionality?
no