Enable noImplicitAny in tsconfig.json#684
Merged
Merged
Conversation
Add a "typecheck" script (tsc --noEmit) to package.json and run it in CI before lint and test. This catches TypeScript type errors that esbuild silently ignores during bundling.
Remove the noImplicitAny: false override so strict: true applies fully. Add explicit type annotations to all callback parameters that were relying on implicit any. Install @types/pluralize for the pluralize package.
9483b02 to
d767f1c
Compare
5585e1a to
2ae6b74
Compare
truggeri
approved these changes
Mar 26, 2026
truggeri
left a comment
Contributor
There was a problem hiding this comment.
I hate using any, but we can "clean" that up with a follow up, so let's merge this now.
Member
Author
|
I feel the same, I investigated that as well last night, but the underlying data structures are coming from external libs and not really typed... we could add an interface, but i'm just hesitant to "mock what I don't own, especially if the library says it's a little bit fluid" But you know a lot more than I do about the Javascript world, maybe that's more idiomatic there? |
This was referenced May 15, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #685.
Removes the
noImplicitAny: falseoverride sostrict: trueapplies fully.Changes
noImplicitAny: falseanytype todependencyandnumbertype toindexin callback paramsanytype toain.find()callbackstringtypes toname,version,directoryparams; addArgvtype to yargs builder callback@types/pluralizedev dependency (thepluralizepackage has no built-in types)Note on
anytypesSome parameters are typed as explicit
anyrather than stricter interfaces. These values come from external sources (YAML-parsed commit metadata and GraphQL responses) where the shape isn't enforced at compile time. Using explicitanykeeps the scope of this PR focused on enablingnoImplicitAny— stricter types for these external data sources can be added separately.tsc --noEmitclean. All 49 tests pass.