Add .tool-versions and .dvmrc support#61
Merged
kt3k merged 16 commits intodenoland:mainfrom Jul 5, 2024
Merged
Conversation
Contributor
Author
|
@kt3k could you take a look at this? Currently required to use asdf in a repository that uses Deno but rather use the setup-deno action with .tool-versions. |
Contributor
|
Thanks for your contribution! Can you add test cases in # ...
test-version-file:
runs-on: ubuntu-latest
strategy:
matrix:
file: [".tool-versions", ".dvmrc"]
steps:
- uses: actions/checkout@v3
- name: Setup Deno
uses: ./
with:
deno-version-file: ${{ matrix.file }}
- name: Check version
run: deno -V | grep -q "deno 1\.43\.1" |
Signed-off-by: Jesse Dijkstra <mail@jessedijkstra.nl>
Signed-off-by: Jesse Dijkstra <mail@jessedijkstra.nl>
Signed-off-by: Jesse Dijkstra <mail@jessedijkstra.nl>
Contributor
Author
|
@kt3k found a bug and fixed it by adding the tests, please take a look again when you have time. |
Contributor
Author
|
Btw, based on the work of #54 :) |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for both .tool-versions and .dvmrc, implementation mirrors that of setup-node