fix(ext/node): add Symbol.dispose and Symbol.asyncDispose to fs.Dir#33000
Merged
bartlomieju merged 2 commits intodenoland:mainfrom Mar 26, 2026
Merged
Conversation
Fixes denoland#32966 Signed-off-by: majiayu000 <1835304752@qq.com>
bartlomieju
requested changes
Mar 25, 2026
Member
There was a problem hiding this comment.
This should be a unit test in tests/unit_node/fs
Address review feedback on PR denoland#33000: replace spec test with a unit test in tests/unit_node/fs_test.ts as requested by @bartlomieju. Signed-off-by: majiayu000 <1835304752@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #32966
Adds
Symbol.disposeandSymbol.asyncDisposeto theDirclass inext/node/polyfills/_fs/_fs_dir.ts, so thatusingandawait usingwork withfs.Dirobjects.[Symbol.dispose]()delegates tocloseSync()(no-op in Deno, mirrors Node behavior)[Symbol.asyncDispose]()delegates toclose()(returnsPromise<void>)FileHandlealready implements[Symbol.asyncDispose]and required no change.Note: This PR was written with AI assistance (Claude).