Skip to content

fix(ext/node): use primordials in ext/node/polyfills/_fs/_fs_lchown.ts#32195

Merged
Tango992 merged 2 commits intodenoland:mainfrom
Haruto-works333:primordials-fs-lchown
Feb 17, 2026
Merged

fix(ext/node): use primordials in ext/node/polyfills/_fs/_fs_lchown.ts#32195
Tango992 merged 2 commits intodenoland:mainfrom
Haruto-works333:primordials-fs-lchown

Conversation

@Haruto-works333
Copy link
Copy Markdown
Contributor

@Haruto-works333 Haruto-works333 commented Feb 16, 2026

Towards #24236

Use primordials in ext/node/polyfills/_fs/_fs_lchown.ts.

Changes:

  • Remove prefer-primordials lint ignore directive
  • Use getValidatedPathToString instead of getValidatedPath().toString()
  • Use PromisePrototypeThen instead of Promise.prototype.then

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Feb 16, 2026 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

bartlomieju
bartlomieju approved these changes Feb 16, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Haruto-works333
Copy link
Copy Markdown
Contributor Author

Haruto-works333 commented Feb 17, 2026

Thank you for reviewing!

@Tango992 Tango992 merged commit a8f201f into denoland:main Feb 17, 2026
86 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Haruto-works333 @CLAassistant @bartlomieju @Tango992