fix(ext/node): handle raw fd instead rid in isatty#31912
Merged
fraidev merged 4 commits intodenoland:mainfrom Feb 4, 2026
Merged
fix(ext/node): handle raw fd instead rid in isatty#31912fraidev merged 4 commits intodenoland:mainfrom
fraidev merged 4 commits intodenoland:mainfrom
Conversation
a035d2f to
e5d5a92
Compare
1 task
bartlomieju
approved these changes
Feb 4, 2026
bartlomieju
added a commit
to bartlomieju/deno
that referenced
this pull request
Mar 28, 2026
This op was added in denoland#31912 but superseded by the libuv-based TTY.isTTY(fd) rewrite in denoland#32777. It is no longer referenced anywhere. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
bartlomieju
added a commit
that referenced
this pull request
Mar 28, 2026
## Summary - Remove `op_node_is_tty` from `ext/node/ops/util.rs` and its registration in `ext/node/lib.rs` - This op was added in #31912 but superseded by the libuv-based `TTY.isTTY(fd)` rewrite in #32777. It is no longer referenced anywhere. Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs:
Previously, isatty(fd) was calling core.isTerminal(fd) which expected a Deno resource ID, but Node.js APIs pass raw OS file descriptors. For fd 0, 1, 2 (stdin/stdout/stderr) this happened to work because rid === fd, but it would fail for higher fds.