fix(ext/node): pass test-child-process-bad-stdio node compat test#31851
Merged
fraidev merged 9 commits intodenoland:mainfrom Jan 28, 2026
Merged
fix(ext/node): pass test-child-process-bad-stdio node compat test#31851fraidev merged 9 commits intodenoland:mainfrom
fraidev merged 9 commits intodenoland:mainfrom
Conversation
b043bf7 to
200bf7d
Compare
5bfb1ae to
e61a28d
Compare
e61a28d to
4b8890d
Compare
68 tasks
bartlomieju
requested changes
Jan 24, 2026
Member
There was a problem hiding this comment.
I think it would be better to land this change in a separate PR with its own tests.
Contributor
Author
There was a problem hiding this comment.
Make sense! Here a PR adding it with tests: #31954
bartlomieju
approved these changes
Jan 27, 2026
Member
bartlomieju
left a comment
There was a problem hiding this comment.
LGTM, please update PR description before landing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs: