fix(ext/node): assert compatibility#31821
Merged
Tango992 merged 17 commits intodenoland:mainfrom Jan 17, 2026
Merged
Conversation
0a8d049 to
288688d
Compare
Tango992
commented
Jan 16, 2026
Comment on lines
+55
to
+58
| let process: NodeJS.Process; | ||
| const lazyLoadProcess = core.createLazyLoader<NodeJS.Process>( | ||
| "node:process", | ||
| ); |
Contributor
Author
There was a problem hiding this comment.
Some imports were changed like this to avoid crashing upon build with
Failed to initialize JsRuntime for snapshotting: CoreError(Js(JsError { name: Some("ReferenceError"), message: Some("Cannot access 'process' before initialization"), stack: None, cause: None, exception_message: "Uncaught ReferenceError: Cannot access 'process' before initialization", frames: [], source_line: None, source_line_frame_index: None, aggregated: None, additional_properties: [] }))
Member
There was a problem hiding this comment.
This is a bit unfortunate, but a good solution to the problem 👍
bartlomieju
reviewed
Jan 17, 2026
Member
There was a problem hiding this comment.
Very nice 👍 it looks like there are still a few test files that are now enabled, let's aim to do that in a separate PR
|
This caused regressions: #31931 |
ChALkeR
added a commit
to ExodusOSS/bytes
that referenced
this pull request
Jan 23, 2026
This was referenced Jan 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the
node:assertmodule based on Node.js v24.12.0, except for the lib/internal/assert/utils.js which requires resolving the error source location based on the source map. This PR removes the compatibility layer with Deno's@std/assert.It enables the following node compatibility tests to pass: