Skip to content

feat(unstable): deploy config allow app to be optional#31567

Merged
crowlKats merged 5 commits intodenoland:mainfrom
crowlKats:deploy-config-optional-app
Dec 12, 2025
Merged

feat(unstable): deploy config allow app to be optional#31567
crowlKats merged 5 commits intodenoland:mainfrom
crowlKats:deploy-config-optional-app

Conversation

@crowlKats
Copy link
Copy Markdown
Member

@crowlKats crowlKats commented Dec 11, 2025

No description provided.

@crowlKats crowlKats mentioned this pull request Dec 11, 2025
Closed
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Dec 11, 2025 •
edited
Loading

Walkthrough

The Pull Request makes DeployConfig.app optional by changing its type from String to Option<String> in libs/config/deno_json/mod.rs. Call sites were updated to handle the optional value: cli/main.rs now validates that an app value exists and returns a descriptive error when it is absent, using the resolved app on success.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: making the app field in deploy config optional.
Description check ✅ Passed No description was provided, but the title is clear enough to understand the change.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@dsherret dsherret changed the title feat(config): deploy config allow app to be optional feat(unstable): deploy config allow app to be optional Dec 11, 2025
dsherret
dsherret approved these changes Dec 11, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dsherret
dsherret reviewed Dec 11, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@dsherret dsherret left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, looks like there is a compiler error.

coderabbitai[bot]
coderabbitai Bot reviewed Dec 11, 2025
View reviewed changes
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7a6a580 and 3d1d37b.

📒 Files selected for processing (1)
  • cli/main.rs (2 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
**/*.rs

📄 CodeRabbit inference engine (CLAUDE.md)

**/*.rs: For debugging Rust code, set breakpoints in IDE debuggers (VS Code with rust-analyzer, IntelliJ IDEA) or use lldb directly
Use eprintln!() or dbg!() macros for debug prints in Rust code

Files:

  • cli/main.rs

⚙️ CodeRabbit configuration file

Don't worry about coverage of Rust docstrings. Don't be nitpicky about it. Leave it to the author's judgement if such a documentation is necessary.

Files:

  • cli/main.rs
cli/main.rs

📄 CodeRabbit inference engine (CLAUDE.md)

Main CLI entry point is in cli/main.rs and should handle command routing

Files:

  • cli/main.rs
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)
  • GitHub Check: test debug windows-x86_64
  • GitHub Check: test debug linux-aarch64
  • GitHub Check: test debug linux-x86_64
  • GitHub Check: test debug macos-x86_64
  • GitHub Check: test release linux-x86_64
  • GitHub Check: test debug macos-aarch64
  • GitHub Check: test release macos-x86_64
  • GitHub Check: lint debug linux-x86_64
  • GitHub Check: lint debug windows-x86_64
  • GitHub Check: lint debug macos-x86_64
  • GitHub Check: build libs
🔇 Additional comments (1)
cli/main.rs (1)

42-42: Import of deno_core::anyhow is appropriate

The new import is necessary for the anyhow::bail! usage below and is consistent with existing anyhow-based error handling in this file.

If you haven’t already, please run cargo check for the CLI crate to ensure there are no unused-import warnings after all PR changes are in place.

Comment thread cli/main.rs
@crowlKats crowlKats merged commit b97dfb0 into denoland:main Dec 12, 2025
20 checks passed
@crowlKats crowlKats deleted the deploy-config-optional-app branch December 12, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@dsherret dsherret dsherret approved these changes

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@crowlKats @dsherret