Skip to content

fix(check): fix nil deref with --unstable-tsgo#31416

Merged
bartlomieju merged 1 commit intodenoland:mainfrom
nathanwhit:tsgo-update-nil-deref
Nov 26, 2025
Merged

fix(check): fix nil deref with --unstable-tsgo#31416
bartlomieju merged 1 commit intodenoland:mainfrom
nathanwhit:tsgo-update-nil-deref

Conversation

@nathanwhit
Copy link
Copy Markdown
Member

@nathanwhit nathanwhit commented Nov 25, 2025 •
edited
Loading

Fixes #31413

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Nov 25, 2025 •
edited
Loading

Walkthrough

Version bump from 0.1.8 to 0.1.9 in a TypeScript Go tooling version file. The download base URL and all five platform-specific SHA256 hashes (Windows x64, macOS x64, macOS ARM64, Linux x64, Linux ARM64) are updated to match the new release. No structural or behavioral changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Single file with only constant value updates
  • Homogeneous changes (repetitive pattern of hash replacements)
  • No logic, control flow, or signature modifications
  • Straightforward verification: confirm version consistency between release tag and hash values

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings, 1 inconclusive)
Check name Status Explanation Resolution
Title check ⚠️ Warning The title claims to fix a nil dereference with --unstable-tsgo, but the changeset only updates version numbers and SHA256 hashes with no functional changes. Update the title to accurately reflect that this is a version bump and hash update, e.g., 'chore(tsgo): bump version to 0.1.9 and update hashes' or reference the actual nil deref fix if present elsewhere.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
Description check ❓ Inconclusive The description references issue #31413 which appears related to the nil deref mentioned in the title, but the actual changes shown are only version and hash updates unrelated to a bug fix. Clarify whether the version bump itself fixes the nil deref issue, or if there are other changes not reflected in the provided summary that address the actual bug.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0bd52c4 and b4542a9.

📒 Files selected for processing (1)
  • cli/tsc/go/tsgo_version.rs (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*.rs

📄 CodeRabbit inference engine (CLAUDE.md)

**/*.rs: For debugging Rust code, set breakpoints in IDE debuggers (VS Code with rust-analyzer, IntelliJ IDEA) or use lldb directly
Use eprintln!() or dbg!() macros for debug prints in Rust code

Files:

  • cli/tsc/go/tsgo_version.rs
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
  • GitHub Check: test debug linux-aarch64
  • GitHub Check: test release linux-x86_64
  • GitHub Check: test debug linux-x86_64
  • GitHub Check: test debug macos-aarch64
  • GitHub Check: test debug windows-x86_64
  • GitHub Check: lint debug windows-x86_64
  • GitHub Check: build libs
  • GitHub Check: lint debug linux-x86_64
🔇 Additional comments (1)
cli/tsc/go/tsgo_version.rs (1)

26-34: Version, URL, and hash updates look consistent

VERSION and DOWNLOAD_BASE_URL are aligned on 0.1.9, and all five platform hashes keep the sha256: prefix expected by the validation block below. Assuming these values came from the generator (tools/update_tsgo.ts) against the 0.1.9 release artifacts, this change set is good to go.

Comment @coderabbitai help to get the list of available commands and usage tips.

@bartlomieju bartlomieju merged commit bcb3312 into denoland:main Nov 26, 2025
32 of 38 checks passed
bartlomieju pushed a commit that referenced this pull request Jan 22, 2026
@nathanwhit @bartlomieju
fix(check): fix nil deref with --unstable-tsgo (#31416)
6eba948 
Fixes #31413
bartlomieju pushed a commit to bartlomieju/deno that referenced this pull request Jan 26, 2026
@nathanwhit @bartlomieju
fix(check): fix nil deref with --unstable-tsgo (denoland#31416)
110f2d5 
Fixes denoland#31413
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

@dsherret dsherret Awaiting requested review from dsherret

@fraidev fraidev Awaiting requested review from fraidev

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

deno check --unstable-tsgo

2 participants

@nathanwhit @bartlomieju