Skip to content

feat: add Float16Array support#31410

Merged
bartlomieju merged 1 commit intodenoland:mainfrom
bartlomieju:deno_core_370
Nov 26, 2025
Merged

feat: add Float16Array support#31410
bartlomieju merged 1 commit intodenoland:mainfrom
bartlomieju:deno_core_370

Conversation

@bartlomieju
Copy link
Copy Markdown
Member

@bartlomieju bartlomieju commented Nov 25, 2025

No description provided.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Nov 25, 2025 •
edited
Loading

Walkthrough

The pull request updates the deno_core dependency from version 0.368.0 to 0.370.0 in the workspace configuration. Additionally, two test expectation entries are added to the WebIDL test manifest for the idlharness tests, specifying expected properties for Module interface objects and their prototypes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Simple version bump with no behavioral changes introduced by this diff itself
  • Pure configuration additions with no conditional logic or complex state management
  • Highly homogeneous changes across both files

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title mentions Float16Array support, but the actual changes only bump deno_core dependency and update WebIDL test expectations—no Float16Array implementation is present in the changeset. Update the title to accurately reflect the changes, such as 'chore: upgrade deno_core to 0.370.0' or 'test: update WebIDL test expectations for Module interface.'
Description check ❓ Inconclusive No description was provided by the author, making it impossible to assess if it relates to the changeset. Add a description explaining the purpose of these changes and why the deno_core dependency was bumped to 0.370.0.
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0bd52c4 and 5b887af.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • Cargo.toml (1 hunks)
  • tests/wpt/runner/expectation.json (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-11-24T16:19:37.808Z 
Learnt from: CR
Repo: denoland/deno PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-24T16:19:37.808Z
Learning: Applies to tests/specs/**/{__test__.jsonc,*.out} : Output assertions in spec tests should use `__test__.jsonc` inline fields or `.out` files with special matching syntax: `[WILDCARD]`, `[WILDLINE]`, `[WILDCHAR]`, `[WILDCHARS(n)]`, `[UNORDERED_START]`/`[UNORDERED_END]`, and `[# comment]`

Applied to files:

  • tests/wpt/runner/expectation.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
  • GitHub Check: test release linux-x86_64
  • GitHub Check: test debug windows-x86_64
  • GitHub Check: test debug linux-aarch64
  • GitHub Check: test debug linux-x86_64
  • GitHub Check: test debug macos-aarch64
  • GitHub Check: build libs
  • GitHub Check: lint debug windows-x86_64
  • GitHub Check: lint debug linux-x86_64
🔇 Additional comments (2)
Cargo.toml (1)

64-64: Straightforward dependency bump to enable Float16Array support.

The bump to deno_core 0.370.0 appears to be the right change, as Float16Array support has been added to deno_core. The version specifier follows the project's conventions and is consistent with similar dependencies.

Please verify that:

  1. deno_core 0.370.0 has been released and is available on crates.io
  2. No breaking API changes between 0.368.0 and 0.370.0 require updates elsewhere in the codebase
  3. The companion changes in tests/wpt/runner/expectation.json (mentioned in the AI summary) align with the expected Float16Array behavior

You can check the crates.io release page or run cargo tree to confirm the version is available and properly resolved.

tests/wpt/runner/expectation.json (1)

5543-5544: Expectation entries look good.

The format is consistent with surrounding entries, and parity between idlharness.any.html and idlharness.any.worker.html is correctly maintained. No issues identified.

Also applies to: 5551-5552

Comment @coderabbitai help to get the list of available commands and usage tips.

nathanwhit
nathanwhit approved these changes Nov 25, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@nathanwhit nathanwhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju enabled auto-merge (squash) November 26, 2025 08:07
@bartlomieju bartlomieju merged commit 26c3f17 into denoland:main Nov 26, 2025
31 of 37 checks passed
@bartlomieju bartlomieju deleted the deno_core_370 branch November 26, 2025 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nathanwhit nathanwhit nathanwhit approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bartlomieju @nathanwhit