Skip to content

fix(bundle): do not error on failing to clean up esbuild dir#31408

Merged
nathanwhit merged 1 commit intodenoland:mainfrom
nathanwhit:esbuild-dir-remove
Nov 26, 2025
Merged

fix(bundle): do not error on failing to clean up esbuild dir#31408
nathanwhit merged 1 commit intodenoland:mainfrom
nathanwhit:esbuild-dir-remove

Conversation

@nathanwhit
Copy link
Copy Markdown
Member

@nathanwhit nathanwhit commented Nov 25, 2025

Fixes #31406

This is just to save some space on the user's device, no need to hard error if it fails.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Nov 25, 2025 •
edited
Loading

Walkthrough

The change modifies the directory cleanup logic in the bundle esbuild tool. Instead of failing when directory removal encounters an error, the code now attempts removal, logs any errors as warnings, and continues execution. This makes the cleanup process non-fatal—if the directory can't be removed, the build proceeds anyway rather than halting.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5–10 minutes

  • Single file with localized error handling modification
  • Straightforward change: direct failure converted to logged warning with continuation
  • Low complexity—standard try-catch/error-logging pattern
  • No new logic branching or state management

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: treating directory cleanup failure as non-fatal rather than a hard error in the esbuild bundle process.
Description check ✅ Passed The description relates to the changeset by referencing the linked issue and explaining the rationale: cleanup is non-critical disk space management.
Linked Issues check ✅ Passed The PR directly addresses issue #31406 by making directory removal non-fatal, allowing the bundle command to succeed even when the esbuild cache directory doesn't exist or fails to delete.
Out of Scope Changes check ✅ Passed The change is narrowly scoped to the esbuild directory cleanup logic in cli/tools/bundle/esbuild.rs, directly addressing the stated objective with no extraneous modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0bd52c4 and ac5619d.

📒 Files selected for processing (1)
  • cli/tools/bundle/esbuild.rs (1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
cli/tools/**/*.rs

📄 CodeRabbit inference engine (CLAUDE.md)

CLI tools should be implemented in cli/tools/<tool> or cli/tools/<tool>/mod.rs

Files:

  • cli/tools/bundle/esbuild.rs
**/*.rs

📄 CodeRabbit inference engine (CLAUDE.md)

**/*.rs: For debugging Rust code, set breakpoints in IDE debuggers (VS Code with rust-analyzer, IntelliJ IDEA) or use lldb directly
Use eprintln!() or dbg!() macros for debug prints in Rust code

Files:

  • cli/tools/bundle/esbuild.rs
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
  • GitHub Check: test debug linux-aarch64
  • GitHub Check: test release linux-aarch64
  • GitHub Check: test debug linux-x86_64
  • GitHub Check: test debug windows-x86_64
  • GitHub Check: test debug macos-aarch64
  • GitHub Check: build libs
  • GitHub Check: lint debug windows-x86_64
  • GitHub Check: lint debug linux-x86_64
🔇 Additional comments (1)
cli/tools/bundle/esbuild.rs (1)

113-119: LGTM! Cleanup is now non-fatal as intended.

The change correctly makes the directory removal non-fatal by using let _ = with inspect_err to log a warning. This fixes the issue where missing or locked directories would cause bundle failures, while still notifying about cleanup problems.

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.

Comment @coderabbitai help to get the list of available commands and usage tips.

@nathanwhit nathanwhit enabled auto-merge (squash) November 25, 2025 16:38
@nathanwhit nathanwhit merged commit 109196c into denoland:main Nov 26, 2025
50 of 54 checks passed
bartlomieju pushed a commit that referenced this pull request Jan 22, 2026
@nathanwhit @bartlomieju
fix(bundle): do not error on failing to clean up esbuild dir (#31408)
6afaeec 
Fixes #31406

This is just to save some space on the user's device, no need to hard
error if it fails.
bartlomieju pushed a commit to bartlomieju/deno that referenced this pull request Jan 26, 2026
@nathanwhit @bartlomieju
fix(bundle): do not error on failing to clean up esbuild dir (denolan…
a1c9978 
…d#31408)

Fixes denoland#31406

This is just to save some space on the user's device, no need to hard
error if it fails.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bundle fails to delete directory

2 participants

@nathanwhit @bartlomieju