fix: skip doing npm resolution in more cases#31305
Merged
dsherret merged 1 commit intodenoland:mainfrom Nov 15, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the deno_semver dependency from version 0.9.0 to 0.9.1 to fix a bug causing unnecessary npm resolution. The update incorporates fixes from two upstream PRs in the deno_semver repository that address npm resolution triggers.
- Updated
deno_semverdependency to version 0.9.1 - Updated corresponding Cargo.lock with new version and checksum
Reviewed Changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Cargo.toml | Bumps deno_semver version constraint from =0.9.0 to =0.9.1 |
| Cargo.lock | Updates deno_semver package version and checksum to match the new dependency version |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
piscisaureus
approved these changes
Nov 15, 2025
bartlomieju
pushed a commit
to bartlomieju/deno
that referenced
this pull request
Nov 17, 2025
There was a bug that was causing npm resolution to occur due to: * denoland/deno_semver#49 Also includes: * denoland/deno_semver#45
bartlomieju
pushed a commit
that referenced
this pull request
Jan 22, 2026
There was a bug that was causing npm resolution to occur due to: * denoland/deno_semver#49 Also includes: * denoland/deno_semver#45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a bug that was causing npm resolution to occur due to:
Also includes: