fix(node/assert): deepStrictEqual now correctly handles Number objects#31233
Merged
Tango992 merged 5 commits intodenoland:mainfrom Nov 18, 2025
Merged
Conversation
Fixes denoland#31172 The deepStrictEqual function was using asserts.equal() which doesn't properly handle boxed primitives like Number objects. Changed it to use isDeepStrictEqual() from comparisons.ts which correctly handles Number, String, Boolean, BigInt, and Symbol objects. Added test cases to verify: - deepStrictEqual throws AssertionError for different Number objects - deepStrictEqual passes for equal Number objects
Contributor
Author
|
@Tango992 The failures likely indicate a pre-existing issue with how parseArgs creates objects or how the tests compare them. Can you please review it and merge if possible? |
…totypes Fix hasOwnProperty and propertyIsEnumerable calls to use Object.prototype methods with .call() to work correctly with objects that have __proto__: null. This fixes the parse-args test failures that occurred after switching deepStrictEqual to use isDeepStrictEqual.
Contributor
Author
|
@Tango992 This is fixed now can you review it? |
Tango992
suggested changes
Nov 11, 2025
Contributor
Tango992
left a comment
There was a problem hiding this comment.
Thanks! Though I have a minor review:
bartlomieju
approved these changes
Nov 17, 2025
Tango992
approved these changes
Nov 18, 2025
Contributor
Author
Thanks @Tango992 |
bartlomieju
pushed a commit
that referenced
this pull request
Jan 22, 2026
#31233) Fixes #31172 ## Description The `deepStrictEqual` function was using `asserts.equal()` which doesn't properly handle boxed primitives like Number objects. Changed it to use `isDeepStrictEqual()` from `comparisons.ts` which correctly handles Number, String, Boolean, BigInt, and Symbol objects. ## Changes - Modified `ext/node/polyfills/assert.ts`: - Added import for `isDeepStrictEqual` from `ext:deno_node/internal/util/comparisons.ts` - Updated `deepStrictEqual` function to use `isDeepStrictEqual()` instead of `asserts.equal()` - Added test cases in `tests/unit_node/assert_test.ts`: - Test that `deepStrictEqual` throws `AssertionError` for different Number objects - Test that `deepStrictEqual` passes for equal Number objects ## Testing Added unit tests to verify: - `deepStrictEqual` throws `AssertionError` for different Number objects (e.g., `new Number(1)` vs `new Number(2)`) - `deepStrictEqual` passes for equal Number objects (e.g., `new Number(1)` vs `new Number(1)`) ## Related Issue #31172 - `assert.deepStrictEqual` does not throw exception for Number objects --------- Co-authored-by: Daniel Rahmanto <daniel.rahmanto@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #31172
Description
The
deepStrictEqualfunction was usingasserts.equal()which doesn't properly handle boxed primitives like Number objects. Changed it to useisDeepStrictEqual()fromcomparisons.tswhich correctly handles Number, String, Boolean, BigInt, and Symbol objects.Changes
Modified
ext/node/polyfills/assert.ts:isDeepStrictEqualfromext:deno_node/internal/util/comparisons.tsdeepStrictEqualfunction to useisDeepStrictEqual()instead ofasserts.equal()Added test cases in
tests/unit_node/assert_test.ts:deepStrictEqualthrowsAssertionErrorfor different Number objectsdeepStrictEqualpasses for equal Number objectsTesting
Added unit tests to verify:
deepStrictEqualthrowsAssertionErrorfor different Number objects (e.g.,new Number(1)vsnew Number(2))deepStrictEqualpasses for equal Number objects (e.g.,new Number(1)vsnew Number(1))Related Issue
#31172 -
assert.deepStrictEqualdoes not throw exception for Number objects