Skip to content

Add reverseproxy tls certificate in New API client#76

Merged
AkshaySainiDell merged 10 commits into
mainfrom
fix-1571-subject-alt-name
Jan 8, 2025
Merged

Add reverseproxy tls certificate in New API client#76
AkshaySainiDell merged 10 commits into
mainfrom
fix-1571-subject-alt-name

Conversation

@AkshaySainiDell

@AkshaySainiDell AkshaySainiDell commented Jan 6, 2025

Copy link
Copy Markdown
Contributor

Description

This PR includes:

  • Add support for reverseproxy tls certificate loading in while creating New API client.
  • UT coverage for pkg - api

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1571

Checklist:

  • Have you run format,vet & lint checks against your submission?
  • Have you made sure that the code compiles?
  • Did you run the unit & integration tests successfully?
  • Have you maintained at least 90% code coverage?
  • Have you commented your code, particularly in hard-to-understand areas
  • Have you done corresponding changes to the documentation
  • Did you run tests in a real Kubernetes cluster?
  • Backward compatibility is not broken

How Has This Been Tested?

  • Deployed the driver using Helm with reverse proxy configured as a sidecar and skipCertificateValidation set to false, then successfully executed the cert-csi scale test.
  • Deployed the driver using Helm with reverse proxy configured as a sidecar and skipCertificateValidation set to true, then successfully executed the cert-csi scale test.
  • Deployed the driver using Helm with reverse proxy configured as a deployment and skipCertificateValidation set to false, then successfully executed the cert-csi scale test.
  • Deployed the driver using Helm with reverse proxy configured as a deployment and skipCertificateValidation set to true, then successfully executed the cert-csi scale test.

@suryagupta4 suryagupta4 changed the title [WIP] Fix 1571 subject alt name Add reverseproxy tls certificate in New API client Jan 8, 2025
@suryagupta4 suryagupta4 marked this pull request as ready for review January 8, 2025 07:51
Comment thread api/api.go
@AkshaySainiDell AkshaySainiDell merged commit 5653dcb into main Jan 8, 2025
@santhoshatdell santhoshatdell deleted the fix-1571-subject-alt-name branch February 27, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants