Skip to content

reverting gonvme mock#63

Merged
mjsdell merged 3 commits into
mainfrom
pvt/revert-mock
Jan 10, 2025
Merged

reverting gonvme mock#63
mjsdell merged 3 commits into
mainfrom
pvt/revert-mock

Conversation

@alikdell

@alikdell alikdell commented Jan 10, 2025

Copy link
Copy Markdown
Collaborator

Description

Reverting gonvme mock file

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
#https://github.com/dell/csm/issues/1559

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test mock file, no test required

@AronAtDell AronAtDell left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for automated dependabot changes only for CSM 1.13 release. Will not include any Engineering code additions.

@mjsdell mjsdell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for automated dependabot changes only for CSM 1.13 release. Will not include any Engineering code additions.

@mjsdell mjsdell merged commit 86bd45e into main Jan 10, 2025
@mjsdell mjsdell deleted the pvt/revert-mock branch January 10, 2025 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants