Skip to content

Added secret inheritance for release action#77

Merged
mjsdell merged 2 commits into
mainfrom
secrets-update
Jan 15, 2025
Merged

Added secret inheritance for release action#77
mjsdell merged 2 commits into
mainfrom
secrets-update

Conversation

@harishp8889

@harishp8889 harishp8889 commented Jan 13, 2025

Copy link
Copy Markdown
Contributor

Description

Added secret inheritance for release action, this is to ensure GPG Key to invoke release guild automation.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1490

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

@prablr79 prablr79 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alikdell alikdell left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for automated dependabot changes only for CSM 1.13 release. Will not include any Engineering code additions.

@AronAtDell AronAtDell left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for GitHub Action changes only for CSM 1.13 release.

@mjsdell mjsdell merged commit 433ce00 into main Jan 15, 2025
@mjsdell mjsdell deleted the secrets-update branch January 15, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants