I'll let others weigh in if they have opinions, but especially in the case of using fleeting runners i think this change makes sense if only to reduce the extra compute cost of spinning up a vm to run commitlint on the draft.

I dont see why this wouldnt work, but since this wont get directly tested from github, @willswire have you tested this in your environment and it works as expected including the job actually triggering when you convert from draft?

GitLab pipelines won't trigger when MR metadata changes (see https://gitlab.com/gitlab-org/gitlab/-/issues/25426 for example), however if a passing pipeline is required, users can just rerun the failed job once the title has changed.

I'll give it a whirl here on GitLab shortly by pointing to this ref.

GitLab pipelines won't trigger when MR metadata changes (see https://gitlab.com/gitlab-org/gitlab/-/issues/25426 for example), however if a passing pipeline is required, users can just rerun the failed job once the title has changed.

I'll give it a whirl here on GitLab shortly by pointing to this ref.

Sounds good and yeah that makes sense we're already tracking that issue it just wasnt in the forefront of my mind when i asked. Hopefully it gets resolved sooner rather than later.

Since this is already a known gap requiring an upstream fix i think its kind of a moot point for the time being and as long as your testing doesn't bubble up some other unexpected behavior we should go ahead and make this change.

No issues found in my tests.

No issues found in my tests.

I approved i'll wait until tomorrow in case anyone else wanted to weigh in before merging but should be good to go.