Skip to content

chore: have addlicense ignore gitignored files#294

Merged
Racer159 merged 7 commits intomainfrom
mjnagel-patch-2
Oct 11, 2024
Merged

chore: have addlicense ignore gitignored files#294
Racer159 merged 7 commits intomainfrom
mjnagel-patch-2

Conversation

@mjnagel
Copy link
Copy Markdown
Collaborator

@mjnagel mjnagel commented Oct 11, 2024

Description

Adds a short script to add -ignore flags for each line in gitignore that is not a comment/empty.

Caveat to this: addlicense does not behave exactly the same as .gitignore, for example afolder in the gitignore file will ignore that entire folder. With the addlicense command it must be folder/**. May necessitate some changes

Checklist before merging

  • ADR proposed if making an architectural change to the repo
  • Tests run, docs added or updated as needed

@mjnagel mjnagel self-assigned this Oct 11, 2024
@mjnagel mjnagel marked this pull request as ready for review October 11, 2024 18:10
@mjnagel mjnagel requested review from a team as code owners October 11, 2024 18:10
@mjnagel mjnagel requested review from a team October 11, 2024 18:10
@Racer159 Racer159 merged commit 1bf662e into main Oct 11, 2024
@Racer159 Racer159 deleted the mjnagel-patch-2 branch October 11, 2024 18:35
This was referenced Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants