Conversation
Collaborator
Author
|
publish job running (doesnt run publish since there isnt a tag/release please PR |
Collaborator
Author
|
Postgres repo i was testing in was missing a root level publish task like uds common has, but its executing correctly otherwise 
|
Racer159
previously approved these changes
Oct 4, 2024
corang
reviewed
Oct 4, 2024
corang
reviewed
Oct 4, 2024
corang
reviewed
Oct 4, 2024
corang
reviewed
Oct 4, 2024
Co-authored-by: Jordan McClintock <jordan@defenseunicorns.com>
corang
approved these changes
Oct 4, 2024
This was referenced Oct 4, 2024
This was referenced Dec 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This issue convert all the common actions into tasks and updates the workflows to all be functioning reusable (callable) workflows.
To upgrade to this version of uds-common once it is released, package developers will need to replace their existing workflows with new ones that call the callable workflows. This is being done by example already in this pr for uds-common itself, but will require slight modification in the package repos.
The specific deviations the package developer will need to make are to update the two uses blocks to be remote refs.
Specifically:
uses: ./.github/workflows/callable-test.yamlwould becomeuses: defenseunicorns/uds-common/.github/workflows/callable-test.yaml@shaand
uses: ./.github/actions/test-flavorwould becomeuses: defenseunicorns/uds-common/.github/actions/test-flavor@shaSimilar updates will need to happen to the lint, release and doc shim workflows in each package repo. After making these changes the branch protections rules will need to be updated to match the new naming schemes.
This update will also require UDS CLI version >= 0.17.0