[examples] fixing some dependencies and test requirements#3605
Merged
Conversation
frankfliu
approved these changes
Feb 7, 2025
ethnzhng
reviewed
Feb 8, 2025
| <version>1.9.0</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>commons-io</groupId> |
Contributor
There was a problem hiding this comment.
Why was the missing dependency only discovered now? Wondering if we need to add some more dep verification checks to the CI
Contributor
There was a problem hiding this comment.
This is transient dependency, it should work even without this. I tested locally, it works, and I didn't see NoClassDefFound org/apache/commons/io/input/UnsynchronizedBufferedReader
siddvenk
approved these changes
Feb 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I was doing some testing the examples with ObjectDetection example, with four of the engines our examples support. PyTorch, TensorFlow, OnnxRuntime and MXNet.
NoClassDefFound org/apache/commons/io/input/UnsynchronizedBufferedReader