fix(beasties): handle empty nested pseudo-selectors

danielroe · danielroe · commit 1d758300ba5a · 2025-04-06T09:36:08.000-07:00
resolves #79
diff --git a/packages/beasties/src/index.ts b/packages/beasties/src/index.ts
@@ -27,6 +27,7 @@ import { createDocument, serializeDocument } from './dom'
 import { createLogger, isSubpath } from './util'
 
 const removePseudoClassesAndElementsPattern = /(?<!\\)::?[a-z-]+(?:\(.+\))?/gi
+const doubleNestingPattern = />\s*(?=>|$)/g
 const removeTrailingCommasPattern = /\(\s*,|,\s*\)/g
 
 export default class Beasties {
@@ -687,6 +688,8 @@ export default class Beasties {
     normalizedSelector = sel
       .replace(removePseudoClassesAndElementsPattern, '')
       .replace(removeTrailingCommasPattern, match => (match.includes('(') ? '(' : ')'))
+      // in case an entire selector is a pseudo-class we need to preserve it
+      .replace(doubleNestingPattern, '> *')
       .trim() as string
 
     this.#selectorCache.set(sel, normalizedSelector)
diff --git a/packages/beasties/test/parse.test.ts b/packages/beasties/test/parse.test.ts
@@ -0,0 +1,34 @@
+import { describe, expect, it, vi } from 'vitest'
+import Beasties from '../src/index'
+
+describe('selector normalisation', () => {
+  it('should handle complex selectors', async () => {
+    vi.spyOn(console, 'warn')
+    const beasties = new Beasties()
+    const result = await beasties.process(`
+      <html>
+        <body>
+          <style> div > :not(.foo) > * { color:red; } </style>
+          <style> div > :not(.foo) { color:red; } </style>
+          <div>
+            <div><div></div></div>
+          </div>
+        </body>
+      </html>
+    `)
+    expect(result.replace(/^ {4}/gm, '')).toMatchInlineSnapshot(`
+      "
+        <html data-beasties-container>
+          <body>
+            <style>div > :not(.foo) > *{color:red}div > :not(.foo){color:red}</style>
+            
+            <div>
+              <div><div></div></div>
+            </div>
+          </body>
+        </html>
+      "
+    `)
+    expect(console.warn).not.toBeCalled()
+  })
+})
