Skip to content

Add gems ejected from future stdlib#1499

Merged
manicmaniac merged 3 commits into
danger:masterfrom
manicmaniac:add-gems-ejected-from-stdlib
Oct 3, 2024
Merged

Add gems ejected from future stdlib#1499
manicmaniac merged 3 commits into
danger:masterfrom
manicmaniac:add-gems-ejected-from-stdlib

Conversation

@manicmaniac

@manicmaniac manicmaniac commented Sep 29, 2024

Copy link
Copy Markdown
Member

Close #1496

I added base64 and pstore gem to runtime dependencies because they will be removed from future Ruby stdlib.

Result

Before this PR

$ OCTOKIT_SILENT=1 bundle exec danger --version
/Users/manicmaniac/Projects/danger/danger/lib/danger/commands/local.rb:1: warning: pstore was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.
You can add pstore to your Gemfile or gemspec to silence this warning.
/Users/manicmaniac/Projects/danger/danger/lib/danger/request_sources/vsts.rb:2: warning: base64 was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.4.0.
You can add base64 to your Gemfile or gemspec to silence this warning.
9.5.0

After this PR

$ OCTOKIT_SILENT=1 bundle exec danger --version
9.5.0

Known issues

According to octokit/octokit.rb#1701 (comment), you need to set OCTOKIT_SILENT environment variable or it prints some other warnings.

$ bundle exec danger --version
To use retry middleware with Faraday v2.0+, install `faraday-retry` gem
To use multipart middleware with Faraday v2.0+, install `faraday-multipart` gem; note: this is used by the ManageGHES client for uploading licenses
9.5.0

@manicmaniac manicmaniac self-assigned this Sep 29, 2024
@manicmaniac manicmaniac marked this pull request as ready for review September 29, 2024 06:50
Comment thread danger.gemspec

spec.required_ruby_version = ">= 2.7.0"

spec.add_runtime_dependency "base64", "~> 0.2"

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread danger.gemspec
spec.add_runtime_dependency "kramdown", "~> 2.3"
spec.add_runtime_dependency "kramdown-parser-gfm", "~> 1.0"
spec.add_runtime_dependency "octokit", ">= 4.0"
spec.add_runtime_dependency "pstore", "~> 0.1"

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@manicmaniac manicmaniac requested a review from orta September 29, 2024 06:51
@manicmaniac manicmaniac changed the title Add gems ejected from stdlib Add gems ejected from future stdlib Sep 29, 2024
@manicmaniac manicmaniac force-pushed the add-gems-ejected-from-stdlib branch from 573e462 to 73fbe8a Compare September 29, 2024 06:55

@orta orta left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me!

@manicmaniac manicmaniac merged commit cd913ea into danger:master Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add pstore to gemspec

2 participants