Skip to content

Bump rubocop version and fix new offenses#1487

Merged
manicmaniac merged 2 commits into
danger:masterfrom
ydah:update-rubocop
Apr 18, 2024
Merged

Bump rubocop version and fix new offenses#1487
manicmaniac merged 2 commits into
danger:masterfrom
ydah:update-rubocop

Conversation

@ydah

@ydah ydah commented Apr 15, 2024

Copy link
Copy Markdown
Contributor

This PR bump rubocop version and fix new offenses.

ydah added 2 commits April 15, 2024 14:01
```
❯ bundle exec rubocop -a

Inspecting 220 files
..........................................................................C...........................C.C......C............................................................................................................

Offenses:

lib/danger/danger_core/environment_manager.rb:111:15: C: [Corrected] Style/RedundantParentheses: Don't use parentheses around a logical expression.
      [title, (subtitle || "")]
              ^^^^^^^^^^^^^^^^
lib/danger/request_sources/bitbucket_cloud.rb:85:24: C: [Corrected] Style/RedundantParentheses: Don't use parentheses around a logical expression.
        has_comments = (warnings.count.positive? || errors.count.positive? || messages.count.positive? || markdowns.count.positive?)
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/danger/request_sources/bitbucket_server.rb:118:24: C: [Corrected] Style/RedundantParentheses: Don't use parentheses around a logical expression.
        has_comments = (warnings.count > 0 || errors.count > 0 || messages.count > 0 || markdowns.count > 0)
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/danger/request_sources/gitlab.rb:307:17: C: [Corrected] Style/RedundantParentheses: Don't use parentheses around a logical expression.
        ref ||= (branch || "master")
                ^^^^^^^^^^^^^^^^^^^^

220 files inspected, 4 offenses detected, 4 offenses corrected
```
@manicmaniac manicmaniac merged commit f7786f4 into danger:master Apr 18, 2024
@ydah ydah deleted the update-rubocop branch April 18, 2024 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants