Skip to content

No need to install gitlab for less than Ruby 2.5.0 #trivial#1449

Merged
orta merged 1 commit into
danger:masterfrom
mataku:feature/stop-gitlab-special-management
Sep 19, 2023
Merged

No need to install gitlab for less than Ruby 2.5.0 #trivial#1449
orta merged 1 commit into
danger:masterfrom
mataku:feature/stop-gitlab-special-management

Conversation

@mataku

@mataku mataku commented Aug 1, 2023

Copy link
Copy Markdown
Contributor

The current required_ruby_version is specified as ">= 2.7.0", so there is no need to consider Ruby version "< 2.7.0".

It seems that the minimum Ruby version was changed to 2.5 in gitlab gem 4.14.1, so special handling was required.

…quired_ruby_version is specified as ">= 2.7.0"
@mataku mataku marked this pull request as ready for review August 1, 2023 14:47
@orta

orta commented Sep 19, 2023

Copy link
Copy Markdown
Member

Agree, thanks!

@orta orta merged commit 905e742 into danger:master Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants