Merged
Conversation
This reverts commit 1693132.
Member
|
Makes sense to me, and given these hooks/methods aren't really available in the Danger DSL, I'd say this isn't a major semver either 👍🏻 |
spencertransier
added a commit
to spencertransier/danger
that referenced
this pull request
Apr 25, 2023
manicmaniac
added a commit
that referenced
this pull request
Apr 26, 2023
…ngelog-entry-for-octokit-upgrade Add CHANGELOG.md entry for PR #1437
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the
octokitdependency from~> 5.0to~> 6.0. The latest version ofoctokitis6.1.1. This change allows projects that usedangerto keep up-to-date with the latestoctokitchanges.This is technically a breaking change because it's jumping from
5.xto6.x. Theoctokit6.0.0release states:I ran the
dangertests locally after upgrading to6.1.1and they all passed successfully.I also searched the
dangercodebase for any uses of theOctokit::Client::AuthorizationsorOctokit::Client::Hooks#available_hooksmodules that were removed in6.0.0and verified that they aren't being used anywhere.