feat: Add new CustomCIWithGithub CI Source Type#1435
Conversation
|
This is a good v0.1 approach. May want to make this its own abstraction for each souce control type (GitHub, Bitbucket, Gitlab, etc). |
77f6245 to
3c5b525
Compare
|
@orta if you have any suggestions on this one or if I'm completely off-base please let me know. Thank you for your time on this codebase. |
|
What is your actual goal with this? We already have some env vars for running a FakeCI in Danger I believe, and this code is effectively duplicating that |
3c5b525 to
228b288
Compare
|
@orta I'm trying to utilize danger against an internal CI system that uses GitHub. Is this a possible use case? The only thing I could find that relates to a To be clear I'm not trying to mock the CI. I would still like danger to run against the PRs. Setting There is a good chance I'm misusing danger and there is a better way to do this. Thank you for any assistance you can provide. Wanted to provide the PR in case there was not a current way. Cheers. |
|
@orta bump |
|
OK, yeah, I think this is reasonable - if you add the inline docs to the class (as it will show up on the site) I'm fine with merging it |
228b288 to
1d6a7fe
Compare
|
Ran tests locally Finished in 59.1 seconds (files took 1.14 seconds to load)
1240 examples, 0 failures, 2 pending |
|
@orta added the inline docs and fixed merge conflict with |
|
@orta bump. Thank you for reviewing. |
Add CI Source that doesn't match any third party vendors (like an internal CI system) but it uses GitHub for source control. Signed-off-by: jmeridth <jmeridth@gmail.com>
95ba130 to
caa4bdb
Compare
orta
left a comment
There was a problem hiding this comment.
Nice, describes it perfectly ππ»
|
Shipped as 9.3.0 |
Add CI Source that doesn't match any third party vendors (like an internal CI system) but it uses GitHub for source control.