Resolve deprecation warnings for example-basic#651
Merged
Conversation
379b585 to
12aeb4a
Compare
Collaborator
Author
|
The result of the checks was successful, apart from the unrelated known problem with example-start / start-multiple-commas, so from my point of view this PR can be merged.
DetailThe PR runs resulted in: The skipped test was release. That is correct. The relevant log for the workflow file example-basic is run 3659480852 which was successful! The only remaining warning (which is really an info) is about macOS: "macOS-latest pipelines will use macOS-12 soon. For more details, see actions/runner-images#6384" I went through each of the sub-logs and they each look correct. The operating system shown under "Set up job" is as expected everywhere. |
This comment was marked as outdated.
This comment was marked as outdated.
4c90487 to
1e71644
Compare
Collaborator
Author
|
The latest run 3706380258 was successful, so this can be merged now. |
Replace Ubuntu 18.04/20.04 combination by Ubuntu 20.04 / 22.04 Bump actions/checkout@v2 to v3 to mitigate Node.js 12 deprecation warning
1e71644 to
3c2575e
Compare
jaffrepaul
approved these changes
Dec 15, 2022
jaffrepaul
approved these changes
Dec 15, 2022
|
🎉 This PR is included in version 5.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
kodiakhq Bot
referenced
this pull request
in weareinreach/InReach
Dec 20, 2022
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/checkout](https://togithub.com/actions/checkout) | action | digest | `7dd9e2a` -> `755da8c` | | [chromaui/action](https://togithub.com/chromaui/action) | action | digest | `0ec8cd8` -> `2440d35` | | [cypress-io/github-action](https://togithub.com/cypress-io/github-action) | action | patch | `v5.0.0` -> `v5.0.2` | | [github/codeql-action](https://togithub.com/github/codeql-action) | action | digest | `a669cc5` -> `959cbb7` | | [tinkurlab/monorepo-pr-labeler-action](https://togithub.com/tinkurlab/monorepo-pr-labeler-action) | action | patch | `4.1.2` -> `4.1.3` | --- ### Release Notes <details> <summary>cypress-io/github-action</summary> ### [`v5.0.2`](https://togithub.com/cypress-io/github-action/releases/tag/v5.0.2) [Compare Source](https://togithub.com/cypress-io/github-action/compare/v5.0.1...v5.0.2) Numerous housekeeping updates to bring this action back up to speed. \*In combination with v5.0.1, which triggered without a new dist build. 👏 Special thanks to [@​MikeMcC399](https://togithub.com/MikeMcC399) for all the diligent work! 👏 **Fix Failed Tests** - [https://github.com/cypress-io/github-action/pull/643](https://togithub.com/cypress-io/github-action/pull/643) - [https://github.com/cypress-io/github-action/pull/658](https://togithub.com/cypress-io/github-action/pull/658) - [https://github.com/cypress-io/github-action/pull/660](https://togithub.com/cypress-io/github-action/pull/660) **Update Dependencies** - [https://github.com/cypress-io/github-action/pull/644](https://togithub.com/cypress-io/github-action/pull/644) - [https://github.com/cypress-io/github-action/pull/650](https://togithub.com/cypress-io/github-action/pull/650) **Resolve Warnings** - [https://github.com/cypress-io/github-action/pull/651](https://togithub.com/cypress-io/github-action/pull/651) - [https://github.com/cypress-io/github-action/pull/666](https://togithub.com/cypress-io/github-action/pull/666) - [https://github.com/cypress-io/github-action/pull/670](https://togithub.com/cypress-io/github-action/pull/670) - [https://github.com/cypress-io/github-action/pull/675](https://togithub.com/cypress-io/github-action/pull/675) **Docs/Example Updates** - [https://github.com/cypress-io/github-action/pull/665](https://togithub.com/cypress-io/github-action/pull/665) - [https://github.com/cypress-io/github-action/pull/668](https://togithub.com/cypress-io/github-action/pull/668) **Tooling Updates:** - [https://github.com/cypress-io/github-action/pull/667](https://togithub.com/cypress-io/github-action/pull/667) - [https://github.com/cypress-io/github-action/pull/677](https://togithub.com/cypress-io/github-action/pull/677) ### [`v5.0.1`](https://togithub.com/cypress-io/github-action/releases/tag/v5.0.1) [Compare Source](https://togithub.com/cypress-io/github-action/compare/v5.0.0...v5.0.1) ##### Bug Fixes - correct .gitignore for videos and screenshots ([89e59e5](https://togithub.com/cypress-io/github-action/commit/89e59e5cfc7760513fe9e9ce4c690345d94eb27a)) </details> <details> <summary>tinkurlab/monorepo-pr-labeler-action</summary> ### [`v4.1.3`](https://togithub.com/TinkurLab/monorepo-pr-labeler-action/releases/tag/4.1.3): Monorepo PR Labeler v4.1.3 [Compare Source](https://togithub.com/tinkurlab/monorepo-pr-labeler-action/compare/4.1.2...4.1.3) Changes include: Bug fix to ignore directories starting with a dot `.` but not directories that contain a dot `.`. According to the docs, this action should ignore mono repos that begin with a dot but it currently ignores also mono repo with a dot even if it is not the first character. Thanks to [@​MoLow](https://togithub.com/MoLow) for the fix! </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/weareinreach/InReach). PR-URL: #107 Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves the deprecation warnings produced by running .github/workflows/example-basic.yml. It solves one item of issue #648 "Deprecated Ubuntu 18.04 used in example workflows".
Previous deprecation warnings
The previous deprecation warnings, for instance in run 3643305670, were:
"Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: actions/checkout@v2"
and
"The ubuntu-18.04 environment is deprecated, consider switching to ubuntu-20.04(ubuntu-latest), or ubuntu-22.04 instead. For more details see actions/runner-images#6002"
Remaining warning
The remaining warning is:
"macOS-latest pipelines will use macOS-12 soon. For more details, see actions/runner-images#6384"
There is nothing which needs to be done about this warning as the action is already successfully running macOS 12.6.1 through macOS-latest. It can be considered as a pure info message.