Skip to content

fix: publish changed docs and examples#996

Merged
nagash77 merged 1 commit intocypress-io:masterfrom
MikeMcC399:publish
Aug 16, 2023
Merged

fix: publish changed docs and examples#996
nagash77 merged 1 commit intocypress-io:masterfrom
MikeMcC399:publish

Conversation

@MikeMcC399
Copy link
Copy Markdown
Collaborator

@MikeMcC399 MikeMcC399 commented Aug 16, 2023

@cypress-app-bot
Copy link
Copy Markdown

cypress-app-bot commented Aug 16, 2023

@MikeMcC399 MikeMcC399 marked this pull request as ready for review August 16, 2023 11:12
@MikeMcC399 MikeMcC399 mentioned this pull request Aug 16, 2023
Merged
@nagash77
Copy link
Copy Markdown

nagash77 commented Aug 16, 2023

Hi @MikeMcC399 , maybe it's just too early for me 😅 , but can you explain what you are trying to do with this PR again because I'm not following.

@MikeMcC399
Copy link
Copy Markdown
Collaborator Author

MikeMcC399 commented Aug 16, 2023 •
edited
Loading

Hi Ben @nagash77

maybe it's just too early for me 😅 , but can you explain what you are trying to do with this PR again because I'm not following.

Sure! There are 25 commits which are in the master branch and that are not in any release. We've been following the practice that documentation changes and example changes do not trigger a release of the action. They're considered secondary, so they are in a sort of intermediate state: committed but not published as part of a release.

However as a tidy-up action before migrating to node20 I want to make sure that these get included in a new release, which would be v5.8.4. That release would get added to the v5 branch and the README would get published to https://www.npmjs.com/package/@cypress/github-action?activeTab=readme which currently hosts an older version.

After the migration to node20, which will be a breaking change causing the creation of a new version and branch v6, then the v5 branch will no longer be changed. So this is about leaving the v5 branch in a clean state.

This PR should move these "pending" commits into a released state.

Hope that's clear?!

git log --oneline
a1d7fa0 (HEAD -> master, upstream/master, upstream/HEAD, origin/master) chore(deps): update cypress to 12.17.4 (#994)
05a8962 docs: rework docker example (#992)
bd079a6 chore(deps): update prettier to 3.0.1 (#993)
790fec3 chore(deps): update dependency node to v18.17.1 (#989)
90dff94 chore(deps): update dependency @types/node to v18.17.3 (#987)
6caf239 test: update component-tests example (#985)
92954d1 chore(deps): update cypress to 12.17.3 (#984)
4ffa371 docs: add missing 5.x features to changelog (#980)
9b69bb5 docs: update compatibility information (#981)
c90607e chore(deps): update dependency @types/node to v18.17.1 (#982)
b3546ce docs: create separate changelog (#979)
79310d5 test: protect yarn pnp example against cypress script redefinition (#967)
bcd73b7 docs: correct typo in PR #975 (#978)
b94beac docs: caution use of start to run tests (#975)
1feef67 docs: add intro to readme for default use (#976)
7690cc6 docs: link recording example to cypress cloud (#977)
814f47b chore(deps): update dependency node to v18.17.0 (#973)
ed6f926 docs: add nodelinker information to yarn modern readme section (#970)
2465849 chore(deps): update cypress to 12.17.2 (#972)
c8b086a docs: correct yarn-modern job name in readme (#966)
7ad5be0 chore(deps): update debug to 4.3.4 (#946)
49af511 docs: explain node.js usage (#961)
aeaeb91 test: remove comment about rebuilding dist in node test (#960)
3881773 chore(deps): update cypress to 12.17.1 (#959)
12a9887 chore(deps): update dependency node to v18.16.1 (#958)
6ea40ba chore(deps): update cypress to 12.17.0 (#955)
d69252d (tag: v5.8.3, upstream/v5, origin/v5, v5) revert: "fix: use yarn instead of npx with yarn.lock (#914)" (#942)

@nagash77
Copy link
Copy Markdown

nagash77 commented Aug 16, 2023

@MikeMcC399 oh that makes sense. Yeah definitely needed my brain to wake up a bit more this morning ha!

@nagash77 nagash77 merged commit 248bde7 into cypress-io:master Aug 16, 2023
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 16, 2023

🎉 This PR is included in version 5.8.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@MikeMcC399 MikeMcC399 deleted the publish branch August 16, 2023 13:09
@MikeMcC399
Copy link
Copy Markdown
Collaborator Author

MikeMcC399 commented Aug 16, 2023

@nagash77

Thanks for merging! I appreciate your cross-checks and questions! Hope you have an enjoyable day 😃 !

@MikeMcC399 MikeMcC399 added documentation Improvements or additions to documentation tests labels Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nagash77 nagash77 nagash77 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation released tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MikeMcC399 @cypress-app-bot @nagash77