revert: "fix: use yarn instead of npx with yarn.lock (#914)"#942
Merged
nagash77 merged 1 commit intocypress-io:masterfrom Jun 15, 2023
Merged
revert: "fix: use yarn instead of npx with yarn.lock (#914)"#942nagash77 merged 1 commit intocypress-io:masterfrom
nagash77 merged 1 commit intocypress-io:masterfrom
Conversation
This reverts commit e08da49.
|
nagash77
approved these changes
Jun 15, 2023
|
🎉 This PR is included in version 5.8.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverts #914 which caused a breaking change due to replacing
npx cypress cache listbyyarn cypress cache listfor Yarn projects.If the working-directory contains a script definition with the name
cypressthen yarn uses this script definition instead of executingcypressfromnode_modules. In the case of issue #941 this caused the workflow to hang indefinitely.PR #914 was intended to resolve an issue with Yarn Modern Plug'n'Play, however the PR is applied to all types of Yarn projects (Classic & Modern).
The changes defined in #914 should be rescheduled for a future date when other breaking changes are planned.
cc: @warrensplayer - Assignee of #914