Skip to content

fix: update dashboard refs to cloud#907

Merged
nagash77 merged 3 commits into
masterfrom
Update-Dashboard-Reference
May 10, 2023
Merged

fix: update dashboard refs to cloud#907
nagash77 merged 3 commits into
masterfrom
Update-Dashboard-Reference

Conversation

@mattvollmer

Copy link
Copy Markdown
Contributor

image

@mattvollmer mattvollmer marked this pull request as ready for review May 10, 2023 15:27
@MikeMcC399

Copy link
Copy Markdown
Collaborator

@mattvCypress

Good catch! The PR is however incomplete and should fail CI as soon as GitHub actions is functional again (see https://www.githubstatus.com/). Check out https://github.com/cypress-io/github-action/blob/master/CONTRIBUTING.md

There are some other places which are still using the "Dashboard" name, including https://github.com/cypress-io/github-action/blob/master/action.yml. These could also be cleaned up.

  record:
    description: 'Sends test results to Cypress Dashboard'
    required: false
    default: false

Perhaps also there should be an additional parameter returned which duplicates dashboardUrl, e.g. cloudRunUrl?

MikeMcC399

This comment was marked as resolved.

@MikeMcC399

Copy link
Copy Markdown
Collaborator

I checked and it works fine if the action is built

image

@elylucas elylucas changed the title Update Dashboard > Cypress Cloud fix: update dashboard refs to cloud May 10, 2023
@elylucas

Copy link
Copy Markdown
Contributor

I checked in the built dist code and updated a few more references. I didn't make any changes to the returned outputs though ATM, that would probably a bit more in-depth and another PR.

@elylucas elylucas requested a review from MikeMcC399 May 10, 2023 16:10
@MikeMcC399

Copy link
Copy Markdown
Collaborator

@elylucas

There are also some references to Cypress Cloud ([Cypress Cloud](https://on.cypress.io/dashboard-introduction)) which forward to https://docs.cypress.io/guides/cloud/introduction. Thanks to the forwarding nothing is broken, but perhaps these links should also be updated now?

@MikeMcC399

This comment was marked as resolved.

@MikeMcC399 MikeMcC399 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elylucas
Great work and thanks for picking up on my feedback!

Skimming through the changes. it all looks fine. I'd like to see CI passing though and hopefully GitHub will be back to full strength soon to do proper checking.

@nagash77 nagash77 merged commit 6e17f67 into master May 10, 2023
@nagash77 nagash77 deleted the Update-Dashboard-Reference branch May 10, 2023 19:52
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 5.7.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants