fix: update dashboard refs to cloud#907
Conversation
mattvollmer
commented
May 10, 2023

|
@mattvCypress Good catch! The PR is however incomplete and should fail CI as soon as GitHub actions is functional again (see https://www.githubstatus.com/). Check out https://github.com/cypress-io/github-action/blob/master/CONTRIBUTING.md There are some other places which are still using the "Dashboard" name, including https://github.com/cypress-io/github-action/blob/master/action.yml. These could also be cleaned up. Perhaps also there should be an additional parameter returned which duplicates |
|
I checked in the built dist code and updated a few more references. I didn't make any changes to the returned outputs though ATM, that would probably a bit more in-depth and another PR. |
|
There are also some references to Cypress Cloud ( |
This comment was marked as resolved.
This comment was marked as resolved.
MikeMcC399
left a comment
There was a problem hiding this comment.
@elylucas
Great work and thanks for picking up on my feedback!
Skimming through the changes. it all looks fine. I'd like to see CI passing though and hopefully GitHub will be back to full strength soon to do proper checking.
|
🎉 This PR is included in version 5.7.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
