Skip to content

fix: harmonize npm name usage in logs#888

Merged
mschile merged 1 commit into
cypress-io:masterfrom
MikeMcC399:fix/npm-naming-action
May 5, 2023
Merged

fix: harmonize npm name usage in logs#888
mschile merged 1 commit into
cypress-io:masterfrom
MikeMcC399:fix/npm-naming-action

Conversation

@MikeMcC399

@MikeMcC399 MikeMcC399 commented Apr 27, 2023

Copy link
Copy Markdown
Collaborator

This PR modifies the action source file index.js for consistency with

  • the npm documentation About npm which uses lower case npm and with
  • the Cypress documentation Module API which does not include NPM in its name

Changes

  • Text and comments now refer to npm consistently in lower case.
  • NPM is removed from the reference to the Cypress Module API

@MikeMcC399

MikeMcC399 commented Apr 27, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

It is the last PR in a series concerned with adding pnpm and Yarn to the list of supported package manager lockfiles supported for installation. This small change triggered a whole lot of other changes making sure that npm was consistently referred to.

When this PR is merged it will trigger an npm release and that will also update the README on https://www.npmjs.com/package/@cypress/github-action, so before that happens all the other documentation changes should have completed.

For some strange reason the README on https://github.com/marketplace/actions/cypress-io is updated even without a release, except that the display of the value of the released version number is only updated with a release to the GitHub Marketplace!

@MikeMcC399 MikeMcC399 force-pushed the fix/npm-naming-action branch 5 times, most recently from d0472f6 to 244872f Compare May 3, 2023 20:01
@MikeMcC399 MikeMcC399 marked this pull request as ready for review May 3, 2023 20:08
@MikeMcC399

MikeMcC399 commented May 4, 2023

Copy link
Copy Markdown
Collaborator Author

Please review. Thanks.

@MikeMcC399 MikeMcC399 force-pushed the fix/npm-naming-action branch from 244872f to 1b7b27a Compare May 5, 2023 14:45
@mschile mschile self-assigned this May 5, 2023
@MikeMcC399

This comment was marked as resolved.

Sign in to view
@MikeMcC399 MikeMcC399 force-pushed the fix/npm-naming-action branch from 1b7b27a to 5e68600 Compare May 5, 2023 15:22
@MikeMcC399

MikeMcC399 commented May 5, 2023

Copy link
Copy Markdown
Collaborator Author

Rebased and ready again 🙂

@MikeMcC399 MikeMcC399 marked this pull request as draft May 5, 2023 15:24
@mschile mschile requested a review from AtofStryker May 5, 2023 15:24
@MikeMcC399 MikeMcC399 force-pushed the fix/npm-naming-action branch from 5e68600 to 957caf4 Compare May 5, 2023 15:28
@MikeMcC399 MikeMcC399 marked this pull request as ready for review May 5, 2023 15:35
@mschile mschile merged commit dfda936 into cypress-io:master May 5, 2023
@github-actions

github-actions Bot commented May 5, 2023

Copy link
Copy Markdown

🎉 This PR is included in version 5.7.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@MikeMcC399 MikeMcC399 deleted the fix/npm-naming-action branch May 5, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mschile mschile mschile approved these changes

@AtofStryker AtofStryker AtofStryker approved these changes

Assignees

@mschile mschile

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MikeMcC399 @mschile @AtofStryker