Skip to content

feat: add auto cancel after failures flag#772

Merged
elylucas merged 12 commits into
masterfrom
add-auto-cancel-after-failures-flag
Feb 27, 2023
Merged

feat: add auto cancel after failures flag#772
elylucas merged 12 commits into
masterfrom
add-auto-cancel-after-failures-flag

Conversation

@elylucas

@elylucas elylucas commented Feb 2, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@CLAassistant

CLAassistant commented Feb 2, 2023 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@elylucas elylucas requested a review from jaffrepaul February 2, 2023 22:51
@elylucas

elylucas commented Feb 2, 2023

Copy link
Copy Markdown
Contributor Author

This is currently marked as a draft as there isn't a published cypress binary to test it with yet.

@jaffrepaul jaffrepaul added the type: enhancement New feature or request label Feb 3, 2023
jaffrepaul
jaffrepaul reviewed Feb 7, 2023
View reviewed changes
Comment thread README.md Outdated
jaffrepaul
jaffrepaul reviewed Feb 7, 2023
View reviewed changes
Comment thread README.md Outdated
MikeMcC399
MikeMcC399 reviewed Feb 7, 2023
View reviewed changes
Comment thread README.md Outdated
elylucas and others added 2 commits February 14, 2023 10:31
@elylucas @jaffrepaul
Update README.md
93a9c10 
Co-authored-by: Paul Jaffre <jaffrepaul@gmail.com>
@elylucas
updating cypress version
6842b09
@MikeMcC399

MikeMcC399 commented Feb 14, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator

@elylucas

You may have noticed that there is a new check which fails here.

You'll need to execute

npm run format
npm run build

and commit the change.

Edit: Also to be safe, you should rebase on master first.

@elylucas

elylucas commented Feb 14, 2023

Copy link
Copy Markdown
Contributor Author

@elylucas

You may have noticed that there is a new check which fails here.

You'll need to execute

npm run format
npm run build

and commit the change.

Edit: Also to be safe, you should rebase on master first.

awesome thanks @MikeMcC399

@MikeMcC399

MikeMcC399 commented Feb 14, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator

@elylucas

I see it's still failing, so the full set of instructions would be:

rebase on current master

npm ci
npm run format
npm run build

(It seems to be the build step which was missing, because your last commit didn't update dist/index.js.)

@elylucas elylucas marked this pull request as ready for review February 14, 2023 23:33
@elylucas elylucas requested review from MikeMcC399 and jaffrepaul and removed request for MikeMcC399 February 14, 2023 23:34
MikeMcC399
MikeMcC399 suggested changes Feb 15, 2023
View reviewed changes

@MikeMcC399 MikeMcC399 left a comment •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elylucas

The new example Specify auto cancel after failures is missing from the table of contents Examples. It should be added.

Please review the order of examples, currently shown as:

image

How about modifying this and changing the order to:

in both the table of contents and the examples themselves. The "Quiet" example seems to be misplaced, which could be handled here or in a separate PR.

This branch is currently 36 commits behind master. I suggest to rebase it on master before it is merged (and to squash commits during merge).

Please set the status of the resolved review comments to "resolved".

@MikeMcC399

MikeMcC399 commented Feb 15, 2023

Copy link
Copy Markdown
Collaborator

@jaffrepaul

Do you consider it necessary / desirable for PRs to be in sync with the base branch (master)? If yes, then you should consider enabling the setting Managing suggestions to update pull request branches.

@MikeMcC399

MikeMcC399 commented Feb 15, 2023

Copy link
Copy Markdown
Collaborator

MikeMcC399
MikeMcC399 reviewed Feb 15, 2023
View reviewed changes
Comment thread README.md Outdated
@MikeMcC399

MikeMcC399 commented Feb 24, 2023

Copy link
Copy Markdown
Collaborator

@elylucas

Is this PR going ahead? It seems like it should, since Cypress 12.6.0 was already released on Feb 15, 2023, but maybe I'm missing part of the big picture.

jaffrepaul
jaffrepaul approved these changes Feb 27, 2023
View reviewed changes

@jaffrepaul jaffrepaul left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@elylucas elylucas merged commit cdbbcd6 into master Feb 27, 2023
@elylucas elylucas deleted the add-auto-cancel-after-failures-flag branch February 27, 2023 16:48
@github-actions

github-actions Bot commented Feb 27, 2023

Copy link
Copy Markdown

🎉 This PR is included in version 5.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@MikeMcC399 MikeMcC399 MikeMcC399 requested changes

@jaffrepaul jaffrepaul jaffrepaul approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

released type: enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@elylucas @CLAassistant @MikeMcC399 @jaffrepaul