Skip to content

Update v12 examples to 12.4.1#747

Merged
jaffrepaul merged 1 commit into
cypress-io:masterfrom
MikeMcC399:update/examples-to-12-latest
Feb 1, 2023
Merged

Update v12 examples to 12.4.1#747
jaffrepaul merged 1 commit into
cypress-io:masterfrom
MikeMcC399:update/examples-to-12-latest

Conversation

@MikeMcC399

@MikeMcC399 MikeMcC399 commented Jan 25, 2023

Copy link
Copy Markdown
Collaborator

This PR updates examples to use the latest Cypress version
12.4.0 released on Jan 24, 2023.
12.4.1 released on Jan 27, 2023.

Each of the test directories in examples, apart from examples/v9, is upgraded to use Cypress 12.4.1.

  1. An issue caused by PR Restructure v9 and v10 examples #727 concerning renaming of the script scripts/npm-install-examples.sh is corrected.

  2. The npm-based examples are updated using:
    npm run install-deps
    This updates package.json to include "cypress": "12.4.1" with exact version number as determined by .npmrc.

  3. examples/start-and-yarn-workspaces is updated using:
    yarn upgrade-interactive --latest

  4. examples/install-command is updated using:
    yarn add cypress -D

  5. examples/basic-pnpm is updated using:
    pnpm update --latest

  6. Edit the run command in .github/workflows/example-install-only.yml run: npm i cypress@12.x.x

@MikeMcC399

This comment was marked as resolved.

@MikeMcC399 MikeMcC399 force-pushed the update/examples-to-12-latest branch from aeae721 to 3c8a252 Compare January 25, 2023 10:40
@MikeMcC399 MikeMcC399 marked this pull request as ready for review January 25, 2023 10:47
@MikeMcC399

Copy link
Copy Markdown
Collaborator Author

@jaffrepaul

Please review and merge this update to the latest Cypress version 12.4.0.

Thanks!

@MikeMcC399 MikeMcC399 force-pushed the update/examples-to-12-latest branch from 3c8a252 to 321a9bc Compare January 25, 2023 21:04
@MikeMcC399 MikeMcC399 marked this pull request as draft January 27, 2023 15:48
@MikeMcC399

This comment was marked as outdated.

@MikeMcC399 MikeMcC399 force-pushed the update/examples-to-12-latest branch from 321a9bc to 6c3456f Compare January 27, 2023 17:14
@MikeMcC399 MikeMcC399 changed the title Update v12 examples to 12.4.0 Update v12 examples to 12.4.1 Jan 27, 2023
@MikeMcC399

Copy link
Copy Markdown
Collaborator Author

This PR, which originally updated the examples to 12.4.0, now updates them to Cypress 12.4.1 instead.

@MikeMcC399 MikeMcC399 force-pushed the update/examples-to-12-latest branch from 6c3456f to 069fe98 Compare January 27, 2023 17:22
@MikeMcC399 MikeMcC399 marked this pull request as ready for review January 27, 2023 17:28
@MikeMcC399

Copy link
Copy Markdown
Collaborator Author

All tests pass, so this PR is ready again for review and merge.

@jaffrepaul jaffrepaul added the type: enhancement New feature or request label Jan 30, 2023
@MikeMcC399 MikeMcC399 force-pushed the update/examples-to-12-latest branch 2 times, most recently from 03394f1 to 4455266 Compare January 31, 2023 14:03
@MikeMcC399

Copy link
Copy Markdown
Collaborator Author

@jaffrepaul

The main reason for wanting to update to Cypress >= 12.4.0 is the support of Vite 4, which enables a new up-to-date setup of Component Testing to be created.

@MikeMcC399 MikeMcC399 force-pushed the update/examples-to-12-latest branch from 4455266 to 3e83b32 Compare January 31, 2023 16:13
@MikeMcC399

Copy link
Copy Markdown
Collaborator Author

@jaffrepaul

@jaffrepaul jaffrepaul left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine so we can move the other PRs along.

Moving forward we should be able to expand and leverage the npm-install-examples script. That's worth a separate task it seems.

@jaffrepaul jaffrepaul removed the type: enhancement New feature or request label Feb 1, 2023
@jaffrepaul jaffrepaul merged commit b739603 into cypress-io:master Feb 1, 2023
@MikeMcC399

Copy link
Copy Markdown
Collaborator Author

@jaffrepaul

Moving forward we should be able to expand and leverage the npm-install-examples script. That's worth a separate task it seems.

Good idea! I will open a new issue to make the suggestion of completing the automation of upgrading to the latest Cypress version so that all types of package managers are covered i.e. add yarn and pnpm.

@MikeMcC399 MikeMcC399 deleted the update/examples-to-12-latest branch February 1, 2023 18:45
@MikeMcC399

Copy link
Copy Markdown
Collaborator Author

There was an error reported in run 7005024879 when merging this PR.

It appears to be a GitHub issue not caused by the repo code, so no special action necessary:

Run ./
/usr/local/bin/npm ci
npm ERR! code ECONNRESET
npm ERR! network aborted
npm ERR! network This is a problem related to network connectivity.
npm ERR! network In most cases you are behind a proxy or have bad network settings.
npm ERR! network 
npm ERR! network If you are behind a proxy, please make sure that the
npm ERR! network 'proxy' config is set properly.  See: 'npm help config'

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/runner/.npm/_logs/2023-02-01T[18](https://github.com/cypress-io/github-action/actions/runs/4067542540/jobs/7005024879#step:3:19)_31_28_082Z-debug-0.log
Error: The process '/usr/local/bin/npm' failed with exit code 1

@jaffrepaul

Copy link
Copy Markdown
Contributor

I reran this as a test for another issue and it's passing now. Will keep an eye on it for flake 

@MikeMcC399

Copy link
Copy Markdown
Collaborator Author

Moving forward we should be able to expand and leverage the npm-install-examples script. That's worth a separate task it seems.

@github-actions

github-actions Bot commented Feb 3, 2023

Copy link
Copy Markdown

🎉 This PR is included in version 5.0.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants