Skip to content

feat: Adding new input command for enabled or not job summary publishment#721

Merged
mjhenkes merged 24 commits into
cypress-io:masterfrom
SoldierBoy31:add-input-for-enable-or-not-job-summary
Mar 8, 2023
Merged

feat: Adding new input command for enabled or not job summary publishment#721
mjhenkes merged 24 commits into
cypress-io:masterfrom
SoldierBoy31:add-input-for-enable-or-not-job-summary

Conversation

@SoldierBoy31

Copy link
Copy Markdown
Contributor

DESCRIPTION

Adding new input "summary" on action file and adding condition before publish job summary. Thereby, if "SUMMARY_ENV_VAR" and summary input is true, the job summary will be publish else not.

IMPROVEMENT WANTED

This will allow to publish or not job summary after ran tests.
This will allow better readability on parallel tests.

…fter ran tests.

This will allow better readability on parallel tests
@CLAassistant

CLAassistant commented Jan 11, 2023

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@SoldierBoy31 SoldierBoy31 changed the title Adding new input command for enabled or not job summary publishment feat: Adding new input command for enabled or not job summary publishment Jan 11, 2023
@jaffrepaul jaffrepaul added the type: enhancement New feature or request label Jan 30, 2023
@kduret

kduret commented Feb 23, 2023

Copy link
Copy Markdown

Hi @jaffrepaul

Sorry to ping you, but is it possible to get a review of this PR 🙏

This option seems very useful 😊

@MikeMcC399

This comment was marked as resolved.

@MikeMcC399

This comment was marked as resolved.

@flotwig flotwig self-requested a review February 23, 2023 16:49
@Thebarda

Copy link
Copy Markdown

Documentation has been added and the branch is synced with the upstream branch

@MikeMcC399

This comment was marked as resolved.

@Thebarda

Copy link
Copy Markdown

@SoldierBoy31 / @Thebarda

This PR fails the check-dist check (see https://github.com/cypress-io/github-action/actions/runs/4284257581/jobs/7460963549). To make this PR up-to-date, you would also need to execute:

npm run format
npm run build

(preferably on an Ubuntu system) and commit the changes.

Does it work on a MacOS?

@MikeMcC399

This comment was marked as resolved.

@Thebarda

Thebarda commented Feb 27, 2023

Copy link
Copy Markdown

Yes I did it on MacOS (latest version).
Edit: Should I add the ; or is it ok?

@MikeMcC399

This comment was marked as resolved.

@Thebarda

Copy link
Copy Markdown

@MikeMcC399 I'm glad that helped you :)
Thanks for your feedbacks!

@flotwig flotwig requested a review from AtofStryker February 28, 2023 15:38
@mjhenkes mjhenkes assigned mjhenkes and unassigned flotwig Feb 28, 2023
Comment thread README.md Outdated
Comment thread README.md Outdated
@Thebarda

Thebarda commented Mar 6, 2023

Copy link
Copy Markdown

@MikeMcC399 @AtofStryker I have taken into account the agreement and update the README file

Comment thread README.md
@MikeMcC399

This comment was marked as resolved.

@Thebarda

Thebarda commented Mar 6, 2023

Copy link
Copy Markdown

@Thebarda

I have taken into account the agreement and update the README file

That looks good. I just made a suggest to add one sentence of text to the explanation. Please consider adding this.

Done ✅

Comment thread README.md Outdated
Co-authored-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
Comment thread README.md Outdated
Co-authored-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>

@MikeMcC399 MikeMcC399 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Thebarda

Thanks again for the changes! It looks good to me now, so we can wait and see what @AtofStryker says.

@MikeMcC399

This comment was marked as resolved.

@Thebarda

Thebarda commented Mar 8, 2023

Copy link
Copy Markdown

@MikeMcC399 Comments are resolved 👍

@MikeMcC399

Copy link
Copy Markdown
Collaborator

@Thebarda

Comments are resolved

Thank you! I also hid my comments which have been completely resolved so that reading the PR is now easier.

@mjhenkes mjhenkes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@mjhenkes mjhenkes merged commit 4d47587 into cypress-io:master Mar 8, 2023
@github-actions

github-actions Bot commented Mar 8, 2023

Copy link
Copy Markdown

🎉 This PR is included in version 5.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@MikeMcC399

MikeMcC399 commented Mar 9, 2023

Copy link
Copy Markdown
Collaborator

@mjhenkes / @jaffrepaul

The same issue has occurred here with a PR that caused a release.

Version 5.3.0 has been correctly published to https://www.npmjs.com/package/@cypress/github-action/v/5.3.0

The GitHub Marketplace https://github.com/marketplace/actions/cypress-io however still shows the previous version, 5.2.0. Publishing to the GitHub Marketplace is a manual process (see https://github.com/cypress-io/github-action/blob/master/DEVELOPMENT.md#updating-the-latest-version-in-github-marketplace).

I'm unsure about the word publishment in the PR title which is unknown by the Cambridge dictionary. Perhaps it is only used in American English?

@mjhenkes

mjhenkes commented Mar 9, 2023

Copy link
Copy Markdown
Contributor

I updated the action in the marketplace.

@MikeMcC399

Copy link
Copy Markdown
Collaborator

@mjhenkes

Thank you! Apparently it is not possible to automate this step - see https://stackoverflow.com/questions/75069692/how-to-automatically-publish-a-github-action-to-the-marketplace.

@mjhenkes

mjhenkes commented Mar 9, 2023

Copy link
Copy Markdown
Contributor

At least the manual step is easy 🤷‍♂️

@jaffrepaul

Copy link
Copy Markdown
Contributor

This is a known "issue". That's why this is called out in https://github.com/cypress-io/github-action/blob/master/DEVELOPMENT.md#updating-the-latest-version-in-github-marketplace and just needs to be monitored during a release. I updated the clunky release description verbiage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released type: enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.