feat: Adding new input command for enabled or not job summary publishment#721
Conversation
…fter ran tests. This will allow better readability on parallel tests
|
Hi @jaffrepaul Sorry to ping you, but is it possible to get a review of this PR 🙏 This option seems very useful 😊 |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
…-input-for-enable-or-not-job-summary
|
Documentation has been added and the branch is synced with the upstream branch |
This comment was marked as resolved.
This comment was marked as resolved.
Does it work on a MacOS? |
This comment was marked as resolved.
This comment was marked as resolved.
|
Yes I did it on MacOS (latest version). |
This comment was marked as resolved.
This comment was marked as resolved.
|
@MikeMcC399 I'm glad that helped you :) |
|
@MikeMcC399 @AtofStryker I have taken into account the agreement and update the README file |
This comment was marked as resolved.
This comment was marked as resolved.
Done ✅ |
Co-authored-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
Co-authored-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
MikeMcC399
left a comment
There was a problem hiding this comment.
Thanks again for the changes! It looks good to me now, so we can wait and see what @AtofStryker says.
This comment was marked as resolved.
This comment was marked as resolved.
|
@MikeMcC399 Comments are resolved 👍 |
Thank you! I also hid my comments which have been completely resolved so that reading the PR is now easier. |
|
🎉 This PR is included in version 5.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
The same issue has occurred here with a PR that caused a release. Version 5.3.0 has been correctly published to https://www.npmjs.com/package/@cypress/github-action/v/5.3.0 The GitHub Marketplace https://github.com/marketplace/actions/cypress-io however still shows the previous version, 5.2.0. Publishing to the GitHub Marketplace is a manual process (see https://github.com/cypress-io/github-action/blob/master/DEVELOPMENT.md#updating-the-latest-version-in-github-marketplace). I'm unsure about the word publishment in the PR title which is unknown by the Cambridge dictionary. Perhaps it is only used in American English? |
|
I updated the action in the marketplace. |
|
Thank you! Apparently it is not possible to automate this step - see https://stackoverflow.com/questions/75069692/how-to-automatically-publish-a-github-action-to-the-marketplace. |
|
At least the manual step is easy 🤷♂️ |
|
This is a known "issue". That's why this is called out in https://github.com/cypress-io/github-action/blob/master/DEVELOPMENT.md#updating-the-latest-version-in-github-marketplace and just needs to be monitored during a release. I updated the clunky release description verbiage. |
DESCRIPTION
Adding new input "summary" on action file and adding condition before publish job summary. Thereby, if "SUMMARY_ENV_VAR" and summary input is true, the job summary will be publish else not.
IMPROVEMENT WANTED
This will allow to publish or not job summary after ran tests.
This will allow better readability on parallel tests.