Skip to content

Update example webpack to run under Node.js 18#708

Merged
jaffrepaul merged 1 commit into
cypress-io:masterfrom
MikeMcC399:fix/webpack
Feb 3, 2023
Merged

Update example webpack to run under Node.js 18#708
jaffrepaul merged 1 commit into
cypress-io:masterfrom
MikeMcC399:fix/webpack

Conversation

@MikeMcC399

@MikeMcC399 MikeMcC399 commented Jan 6, 2023

Copy link
Copy Markdown
Collaborator

This PR resolves issue #686 "webpack examples fail locally on Node.js 18 (LTS)"

For

in webpack.config.js

the versions of the following npm packages are bumped:

finally

  • a .gitignore file is added, which contains dist/, to ensure that a local run of the test does not inadvertently cause files created by the test to be committed to the repository.

Verification

GitHub test

Check the Actions log on https://github.com/cypress-io/github-action/actions/workflows/example-webpack.yml?query=branch%3Amaster and ensure that the Status is "Success"

Local test

Open a terminal window on a local clone of the repository:

cd examples/v9/webpack
nvm use 18.13.0
npm ci
npx webpack

Ensure that the output is:
"webpack 5.75.0 compiled successfully"
and that there are no error messages displayed.

Following on from the previous test to check in examples/webpack

cd ../../webpack
nvm use 18.13.0
npm ci
npx webpack

Ensure that the output is:
"webpack 5.75.0 compiled successfully"
and that there are no error messages displayed.

Execute

git status

and check that no new files are found by git.

@MikeMcC399

This comment was marked as outdated.

@MikeMcC399 MikeMcC399 marked this pull request as ready for review January 20, 2023 10:56
@MikeMcC399

This comment was marked as outdated.

@MikeMcC399 MikeMcC399 marked this pull request as draft January 25, 2023 08:15
@MikeMcC399

This comment was marked as outdated.

example webpack can now run under Node.js 14, 16 & 18
@MikeMcC399

Copy link
Copy Markdown
Collaborator Author

@jaffrepaul

This PR is now rebased and ready for review and merge.

@jaffrepaul jaffrepaul left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jaffrepaul jaffrepaul merged commit 83950ad into cypress-io:master Feb 3, 2023
@MikeMcC399 MikeMcC399 deleted the fix/webpack branch February 3, 2023 16:19
@github-actions

github-actions Bot commented Feb 3, 2023

Copy link
Copy Markdown

🎉 This PR is included in version 5.0.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants