Merged
Conversation
Some of tests were broken when running in Windows. These changes take steps towards making the tests platform-agnostic. Conversely, the main logic was not taking into account the Volume name, which could lead to invalid paths being generated. Signed-off-by: Paulo Gomes <pjbgf@linux.com>
cyphar
approved these changes
Sep 6, 2023
Owner
cyphar
left a comment
There was a problem hiding this comment.
LGTM, thanks for finding this! I will make an advisory and do a release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of tests were broken when running in Windows. These changes take steps towards making the tests platform-agnostic. Conversely, the main logic was not taking into account the Volume name, which could lead to invalid paths being generated.
Volume paths in
unsafePathare now ignored.