Skip to content

Conversation

@mpkorstanje
Copy link
Contributor

@mpkorstanje mpkorstanje commented Jun 1, 2025

🤔 What's changed?

Refactor TeamCityPlugin to use messages.

Depends on cucumber/query#76.

⚡️ What's your motivation?

Partially implement: #3001

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

@mpkorstanje mpkorstanje mentioned this pull request Jun 1, 2025
11 tasks
@mpkorstanje mpkorstanje changed the title Use a message based TeamCityPlugin (#2638) Use a message based TeamCityPlugin Jun 1, 2025
@mpkorstanje mpkorstanje mentioned this pull request Jun 6, 2025
7 tasks
mpkorstanje added a commit to cucumber/query that referenced this pull request Jun 10, 2025
* Added several new methods to find pickles, testcases, test cast started
  and test steps by `TestStepStarted` events.
* Made lineage API public.

While Converting the TeamCity plugin to the message protocol[1] I found
that.  Unlike the JUnit XML formatter this plugin also responds to test
steps and so needs queries that involve test steps.

The plugin also needs to transform the elements in the Pickle tree to
something more complex than a name so the lineage api is made public.

1. cucumber/cucumber-jvm#3007

Co-authored-by: David Goss <david@davidgoss.co>
@mpkorstanje mpkorstanje marked this pull request as ready for review June 10, 2025 13:07
@mpkorstanje
Copy link
Contributor Author

Currently we don't have a message based equivalent for suggested snippets yet. So we aren't completely done yet but this is good enough for now.

@mpkorstanje mpkorstanje merged commit 9d7b1e3 into main Jun 10, 2025
6 checks passed
@mpkorstanje mpkorstanje deleted the refactor/teamcity-plugin-use-messages branch June 10, 2025 13:10
mpkorstanje added a commit that referenced this pull request Aug 18, 2025
The partially message based implementation doesn't support parallelism
correctly.

Fixes: #3042
Reverts: 9d7b1e3
mpkorstanje added a commit that referenced this pull request Aug 18, 2025
The partially message based implementation doesn't support parallelism
correctly.

Fixes: #3042
Reverts: 9d7b1e3
mpkorstanje added a commit that referenced this pull request Aug 18, 2025
The partially message based implementation doesn't support parallelism
correctly.

Fixes: #3042
Reverts: 9d7b1e3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant