fix(postcss-convert-values): preserve percent sign in percentage values in at-rules with double quotes #1695
Conversation
…es in at-rules with double quotes
|
/cc @ludofischer can you help me with the release after merge this? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1695 +/- ##
=======================================
Coverage 98.54% 98.54%
=======================================
Files 122 122
Lines 10388 10388
Branches 18 18
=======================================
Hits 10237 10237
Misses 151 151 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@alexander-akait Yes I can release after merging this if you want |
|
@ludofischer Thank you |
|
Related to this, but shouldn't it also keep the While investigating tailwindlabs/tailwindcss#17977 I found this PR in the hopes it would solve my issue too, but I just noticed this is just about different ways of quoting percentage, and it doesn't account for my syntax. Edit: I've added a PR to solve it here: #1702 |
Fixes #1694
The
shouldKeepZeroUnitcheck previously expected the syntax value<percentage>to be enclosed only in single quotes. However, in CSS, string values can also be surrounded by double quotes. I've added an additional check to handle both quote styles and updated the test cases to include the double-quoted variant.NOTE: I didn't change any logic in
packages/postcss-minify-selectors/test/index.js, but the file was automatically updated after running thepnpm fixlintcommand.