libvirt/constants.go: Add arch info to download machine-driver-libvirt binary

praveenkumar · praveenkumar · commit 926c78e6bfc6 · 2024-06-27T13:02:24.000+05:30
machine-driver-libvirt now have arm64 and amd64 binary for linux platfrom. This PR will make sure correct binary is downloaded and used for specific platform. Name of the binary should be `machine-driver-libvirt` because this name is hard-coded as part of the plugin - https://github.com/crc-org/machine/blob/master/libmachine/drivers/plugin/localbinary/plugin.go#L55-L63 Now during start user get follow warning which need to be ignored ``` WARN Executable name is crc-driver-libvirt but extracted file name is crc-driver-libvirt-amd64 ```
diff --git a/pkg/crc/machine/libvirt/constants.go b/pkg/crc/machine/libvirt/constants.go
@@ -5,6 +5,7 @@ package libvirt
 
 import (
 	"fmt"
+	"runtime"
 
 	"github.com/crc-org/crc/v2/pkg/crc/constants"
 )
@@ -25,7 +26,7 @@ const (
 )
 
 var (
-	MachineDriverDownloadURL = fmt.Sprintf("https://github.com/crc-org/machine-driver-libvirt/releases/download/%s/%s", MachineDriverVersion, machineDriverCommand)
+	MachineDriverDownloadURL = fmt.Sprintf("https://github.com/crc-org/machine-driver-libvirt/releases/download/%s/%s-%s", MachineDriverVersion, machineDriverCommand, runtime.GOARCH)
 )
 
 func MachineDriverPath() string {

Original file line number	Diff line number	Diff line change
`@@ -5,6 +5,7 @@ package libvirt`
`5`	`5`
`6`	`6`	`import (`
`7`	`7`	`"fmt"`
	`8`	`+ "runtime"`
`8`	`9`
`9`	`10`	`"github.com/crc-org/crc/v2/pkg/crc/constants"`
`10`	`11`	`)`
`@@ -25,7 +26,7 @@ const (`
`25`	`26`	`)`
`26`	`27`
`27`	`28`	`var (`
`28`		`- MachineDriverDownloadURL = fmt.Sprintf("https://github.com/crc-org/machine-driver-libvirt/releases/download/%s/%s", MachineDriverVersion, machineDriverCommand)`
	`29`	`+ MachineDriverDownloadURL = fmt.Sprintf("https://github.com/crc-org/machine-driver-libvirt/releases/download/%s/%s-%s", MachineDriverVersion, machineDriverCommand, runtime.GOARCH)`
`29`	`30`	`)`
`30`	`31`
`31`	`32`	`func MachineDriverPath() string {`