Fix: go-lint fixes for go tools 0.24.0 update

vyasgun · praveenkumar · commit 8a88ac761757 · 2024-08-13T09:46:47.000Z
Related PR: #4316
diff --git a/cmd/crc/cmd/root.go b/cmd/crc/cmd/root.go
@@ -81,7 +81,7 @@ func runPrerun(cmd *cobra.Command) error {
 	logging.InitLogrus(logFile)
 
 	for _, str := range defaultVersion().lines() {
-		logging.Debugf(str)
+		logging.Debugf("%s", str)
 	}
 	return nil
 }
@@ -138,7 +138,7 @@ func setProxyDefaults() error {
 	}
 
 	if proxyConfig.IsEnabled() {
-		logging.Debugf(proxyConfig.String())
+		logging.Debugf("%s", proxyConfig.String())
 		proxyConfig.ApplyToEnvironment()
 	}
 	return nil
diff --git a/pkg/crc/input/input.go b/pkg/crc/input/input.go
@@ -15,7 +15,7 @@ func PromptUserForYesOrNo(message string, force bool) bool {
 		return false
 	}
 	var response string
-	fmt.Printf(message + "? [y/N]: ")
+	fmt.Printf("%s? [y/N]: ", message)
 	_, _ = fmt.Scanf("%s", &response)
 
 	return strings.ToLower(response) == "y"
diff --git a/pkg/crc/preflight/preflight.go b/pkg/crc/preflight/preflight.go
@@ -72,7 +72,7 @@ func (check *Check) doFix() error {
 		panic(fmt.Sprintf("Should not happen, empty description for fix '%s'", check.configKeySuffix))
 	}
 	if check.flags&NoFix == NoFix {
-		return fmt.Errorf(check.fixDescription)
+		return fmt.Errorf("%s", check.fixDescription)
 	}
 
 	logging.Infof("%s", check.fixDescription)

Original file line number	Diff line number	Diff line change
`@@ -81,7 +81,7 @@ func runPrerun(cmd *cobra.Command) error {`
`81`	`81`	`logging.InitLogrus(logFile)`
`82`	`82`
`83`	`83`	`for _, str := range defaultVersion().lines() {`
`84`		`- logging.Debugf(str)`
	`84`	`+ logging.Debugf("%s", str)`
`85`	`85`	`}`
`86`	`86`	`return nil`
`87`	`87`	`}`
`@@ -138,7 +138,7 @@ func setProxyDefaults() error {`
`138`	`138`	`}`
`139`	`139`
`140`	`140`	`if proxyConfig.IsEnabled() {`
`141`		`- logging.Debugf(proxyConfig.String())`
	`141`	`+ logging.Debugf("%s", proxyConfig.String())`
`142`	`142`	`proxyConfig.ApplyToEnvironment()`
`143`	`143`	`}`
`144`	`144`	`return nil`
Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@ func PromptUserForYesOrNo(message string, force bool) bool {`
`15`	`15`	`return false`
`16`	`16`	`}`
`17`	`17`	`var response string`
`18`		`- fmt.Printf(message + "? [y/N]: ")`
	`18`	`+ fmt.Printf("%s? [y/N]: ", message)`
`19`	`19`	`_, _ = fmt.Scanf("%s", &response)`
`20`	`20`
`21`	`21`	`return strings.ToLower(response) == "y"`
Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,7 @@ func (check *Check) doFix() error {`
`72`	`72`	`panic(fmt.Sprintf("Should not happen, empty description for fix '%s'", check.configKeySuffix))`
`73`	`73`	`}`
`74`	`74`	`if check.flags&NoFix == NoFix {`
`75`		`- return fmt.Errorf(check.fixDescription)`
	`75`	`+ return fmt.Errorf("%s", check.fixDescription)`
`76`	`76`	`}`
`77`	`77`
`78`	`78`	`logging.Infof("%s", check.fixDescription)`