build: Ensure binaries are rebuilt on any source change

cfergeau · cfergeau · commit 16cf22d9b9e8 · 2024-07-30T14:24:18.000+02:00
The Makefile has a `SOURCES` variable which contains a list of all go source files used by crc. It's used as a dependency for the targets building binaries so that the binaries are rebuilt on any source changes. This broke in 1d10459 when a release_info_test.go file was added to the top level directory. Since `SOURCES` is set to `git ls-files *.go ":^vendor"` shell expansion will happen before `git ls-files` runs, so we'll be running `git ls-files release_info_test.go ":^vendor"`, the `SOURCES` variable will only contain `release_info_test.go` instead of the list of all source files, and binaries won't get rebuilt when one of the go files change. This commit adds quoting around `*.go` so that this works properly. Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
diff --git a/Makefile b/Makefile
@@ -36,7 +36,7 @@ ORG := github.com/crc-org
 MODULEPATH = $(ORG)/crc/v2
 PACKAGE_DIR := packaging/$(GOOS)
 
-SOURCES := $(shell git ls-files  *.go ":^vendor")
+SOURCES := $(shell git ls-files '*.go' ":^vendor")
 
 RELEASE_INFO := release-info.json
 
