Skip to content

fix(prompt): prompt does not respect [body-leading-blank] setting#4066

Merged
escapedcat merged 2 commits intoconventional-changelog:masterfrom
weixinwu:fix/body-leading-blank-setting-in-prompt
May 9, 2024
Merged

fix(prompt): prompt does not respect [body-leading-blank] setting#4066
escapedcat merged 2 commits intoconventional-changelog:masterfrom
weixinwu:fix/body-leading-blank-setting-in-prompt

Conversation

@weixinwu
Copy link
Copy Markdown
Contributor

@weixinwu weixinwu commented May 6, 2024

Description

My attempt to fix the prompt not respecting body-leading-blank setting issue in #3826 .

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci bot commented May 6, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@escapedcat
Copy link
Copy Markdown
Member

Any way to add add a test for this?:
https://github.com/conventional-changelog/commitlint/blob/88cb735e96f05ad3a998356c95eb00527e54bb9f/%40commitlint/prompt/src/input.test.ts

@escapedcat escapedcat merged commit 3f1f44d into conventional-changelog:master May 9, 2024
@escapedcat
Copy link
Copy Markdown
Member

Thx @weixinwu !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants